.../boot/dts/rockchip/rk3399-pinephone-pro.dts | 40 ++++++++++++++++++++-- 1 file changed, 38 insertions(+), 2 deletions(-)
Throughout the years, many have contributed to the Pinephone Pro (ppp) development. Unfortunately, these patches are scattered around various repositories in different states. I will be attempting to upstream these patches. I will start off with the following small series: - Add light/proximity sensor support - Link: https://codeberg.org/megi/linux/commit/f171bc7013bc7ad3de9af817bfbcbfa548ebe01c - Add accelerometer sensor support - Link: https://codeberg.org/megi/linux/commit/b0bb7633e073a6760fa213b8c4a78ea2e73c7bf1 - Add magnetometer sensor support - Link: https://codeberg.org/megi/linux/commit/2f7e67f451f16eaf15b81aa1dbdf126d54927d35 - Add mount-matrix for magnetometer - Link: https://codeberg.org/megi/linux/commit/d7cd2eab931e32fa94408a96d73b4e6c0616107a - Fix voltage threshold for volume down key - Link: https://codeberg.org/megi/linux/commit/7c496a5cc27ed4e38b740f36c2d8b2c62f80ae54 Unfortunately, because most of userspace (plasma, phosh, kompass, hwtest, etc.) use the ppp's downstream kernel as a reference, the incorrect mount matrix for accelerometer and magnetometer have propogated to userspace, and therefore we can't use them for testing as they will give the wrong result. Instead, we have to read the raw values from the device and compare it to https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/iio/mount-matrix.txt#L80-L90 as that will lead to the correct result I would request reviewers to look at the mount-matrix tests and help me see if they make sense. I've read the mount-matrix documentation, but it isn't really clear to me if the values in the tests are the values I should be getting Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> --- Changes in v4: - remove leda-supply and vdd-supply from dts to suppress warning - credit Martijn and Kamil for the light sensor and accelerometer patches - Link: https://fosstodon.org/@martijnbraam/115272859701389599 - Link: https://codeberg.org/megi/linux/commit/fc5660685ebe4ecf60226bfa27a1ce47c1c1d020 - combine the magnetometer related patches - corrected accelerometer's mount matrix to Documentation/devicetree/bindings/iio/mount-matrix.txt - filled out commit messages - rebased onto v6.17 - Link to v3: https://lore.kernel.org/r/20250921-ppp_light_accel_mag_vol-down-v3-0-7af6651f77e4@gmail.com Changes in v3: - change magnetometer mount matrix - update volume button threshold - Link to v2: https://lore.kernel.org/r/20250921-ppp_light_accel_mag_vol-down-v2-0-e6bcc6ca74ae@gmail.com Changes in v2: - remove usb-typec node in dts from light/proximity sensor patch - Link to v1: https://lore.kernel.org/r/20250920-ppp_light_accel_mag_vol-down-v1-0-c8bbcd3e2e94@gmail.com --- Ondrej Jirman (4): arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor support arm64: dts: rk3399-pinephone-pro: Add accelerometer sensor support arm64: dts: rk3399-pinephone-pro: Add magnetometer sensor support arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for volume keys .../boot/dts/rockchip/rk3399-pinephone-pro.dts | 40 ++++++++++++++++++++-- 1 file changed, 38 insertions(+), 2 deletions(-) --- base-commit: e5f0a698b34ed76002dc5cff3804a61c80233a7a change-id: 20250920-ppp_light_accel_mag_vol-down-817c84fdae8d Best regards, -- Rudraksha Gupta <guptarud@gmail.com>
Hello Rudraksha, On 2025-09-29 09:35, Rudraksha Gupta via B4 Relay wrote: > arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor > support > arm64: dts: rk3399-pinephone-pro: Add accelerometer sensor > support > arm64: dts: rk3399-pinephone-pro: Add magnetometer sensor support > arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for > volume keys Please note that the patch summaries/subjects are still a bit wrong in the v4 of this series, because there should be no "rk3399-pinephone-pro:" prefixes in them. You can always check the commit history for the file you're editing, to see what's the expected format of the patch summary. It differs a bit between the subsystems and architectures, so it should always be checked.
Am Montag, 29. September 2025, 10:32:59 Mitteleuropäische Sommerzeit schrieb Dragan Simic: > Hello Rudraksha, > > On 2025-09-29 09:35, Rudraksha Gupta via B4 Relay wrote: > > arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor > > support > > arm64: dts: rk3399-pinephone-pro: Add accelerometer sensor > > support > > arm64: dts: rk3399-pinephone-pro: Add magnetometer sensor support > > arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for > > volume keys > > Please note that the patch summaries/subjects are still a bit > wrong in the v4 of this series, because there should be no > "rk3399-pinephone-pro:" prefixes in them. > > You can always check the commit history for the file you're > editing, to see what's the expected format of the patch summary. > It differs a bit between the subsystems and architectures, so > it should always be checked. for reference for Rockchip dts files, the preferred format is: arm64: dts: rockchip: Do something on boardname aka "arm64: dts: rockchip: " and the rest is free form but should mention the board. But I'll generally fix those up myself if needed, so right now there is no need to resend just for that change. Heiko
© 2016 - 2025 Red Hat, Inc.