1. Patchew
  2. linux
  3. View series

[PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins

Eric Gonçalves posted 1 patch 3 days, 15 hours ago
There is a newer version of this series
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
Posted by Eric Gonçalves 3 days, 15 hours ago 
The S20 series has additional reserved pins for the fingerprint sensor,
GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.

Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
---
Changes in v2:
- Fixed the formatting of the <40 4> line
- Added Fixes tag
---
 arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
index 96662bf9e527..a87e3d23e3e2 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
@@ -159,7 +159,8 @@ &pon_resin {
 };
 
 &tlmm {
-	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
+	gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
+					       <40 4>, /* Unused */
 };
 
 &usb_1 {
-- 
2.51.0
Re: [PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
Posted by Konrad Dybcio 11 hours ago 
On 9/28/25 6:45 AM, Eric Gonçalves wrote:
> The S20 series has additional reserved pins for the fingerprint sensor,
> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
> 
> Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> ---
> Changes in v2:
> - Fixed the formatting of the <40 4> line
> - Added Fixes tag
> ---
>  arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> index 96662bf9e527..a87e3d23e3e2 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> @@ -159,7 +159,8 @@ &pon_resin {
>  };
>  
>  &tlmm {
> -	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
> +	gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
> +					       <40 4>, /* Unused */

Please set your tab width to 8 :)

Konrad
Re: [PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
Posted by Dmitry Baryshkov 3 days, 14 hours ago 
On Sun, Sep 28, 2025 at 04:45:33AM +0000, Eric Gonçalves wrote:
> The S20 series has additional reserved pins for the fingerprint sensor,
> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
> 
> Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> ---
> Changes in v2:
> - Fixed the formatting of the <40 4> line
> - Added Fixes tag
> ---
>  arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> index 96662bf9e527..a87e3d23e3e2 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> @@ -159,7 +159,8 @@ &pon_resin {
>  };
>  
>  &tlmm {
> -	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
> +	gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
> +					       <40 4>, /* Unused */

This is still not aligned to the opening angle bracket. Could you please
recheck your setup?

>  };
>  
>  &usb_1 {
> -- 
> 2.51.0
> 

-- 
With best wishes
Dmitry
Re: [PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
Posted by Eric Gonçalves 3 days, 13 hours ago 

On September 28, 2025 3:11:16 AM GMT-03:00, Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote:
>On Sun, Sep 28, 2025 at 04:45:33AM +0000, Eric Gonçalves wrote:
>> The S20 series has additional reserved pins for the fingerprint sensor,
>> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
>> 
>> Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
>> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
>> ---
>> Changes in v2:
>> - Fixed the formatting of the <40 4> line
>> - Added Fixes tag
>> ---
>>  arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> index 96662bf9e527..a87e3d23e3e2 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> @@ -159,7 +159,8 @@ &pon_resin {
>>  };
>>  
>>  &tlmm {
>> -	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
>> +	gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
>> +					       <40 4>, /* Unused */
>
>This is still not aligned to the opening angle bracket. Could you please
>recheck your setup?
Yeah, sorry, I had it set to 4 spaces still - I sent a v3.
>
>>  };
>>  
>>  &usb_1 {
>> -- 
>> 2.51.0
>> 
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.