[PATCH v3 06/11] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path

Paul Sajna posted 11 patches 4 months, 2 weeks ago
There is a newer version of this series
[PATCH v3 06/11] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
Posted by Paul Sajna 4 months, 2 weeks ago
Add paths for Qualcomm firmware, including:
ipa, modem, bluetooth, venus, gpu

Enable adsp and cdsp nodes since their firmware is present

GPU and bluetooth are confirmed working, others may need more
testing/fixes

But regardless they will need the firmware paths specified here
and firmware added upstream before they will work, so might as well
get started on it now.

Paths changed to qcom/sdm845/lg/judyln

Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 10 ++++++++++
 arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  | 26 +++++++++++++++++---------
 2 files changed, 27 insertions(+), 9 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index aa338612433f9ac3b07363b79d8a3b8e0eedd98b..0f0a3f471f48e26cc48feb1551093599fcb35d7f 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -173,6 +173,10 @@ &adsp_pas {
 	status = "okay";
 };
 
+&cdsp_pas {
+	status = "okay";
+};
+
 &apps_rsc {
 	regulators-0 {
 		compatible = "qcom,pm8998-rpmh-regulators";
@@ -479,6 +483,8 @@ zap-shader {
 
 &ipa {
 	qcom,gsi-loader = "modem";
+	memory-region = <&ipa_fw_mem>;
+
 	status = "okay";
 };
 
@@ -668,3 +674,7 @@ bluetooth: bluetooth {
 &uart9 {
 	status = "okay";
 };
+
+&venus {
+	status = "okay";
+};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index f45eb1dfe55c562142092a4239758609fa3f2e47..d60094f864605f7e454693d73efb63b9a099ecad 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -35,19 +35,23 @@ battery: battery {
 };
 
 &adsp_pas {
-	firmware-name = "qcom/sdm845/judyln/adsp.mbn";
+	firmware-name = "qcom/sdm845/lg/judyln/adsp.mbn";
 };
 
 &cdsp_pas {
-	firmware-name = "qcom/sdm845/judyln/cdsp.mbn";
+	firmware-name = "qcom/sdm845/lg/judyln/cdsp.mbn";
 };
 
 &gpu {
 	zap-shader {
-		firmware-name = "qcom/sdm845/judyln/a630_zap.mbn";
+		firmware-name = "qcom/sdm845/lg/judyln/a630_zap.mbn";
 	};
 };
 
+&ipa {
+	firmware-name = "qcom/sdm845/lg/judyln/ipa_fws.mbn";
+};
+
 &mdss {
 	status = "okay";
 };
@@ -90,7 +94,7 @@ &mdss_dsi0_out {
 };
 
 &mss_pil {
-	firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
+	firmware-name = "qcom/sdm845/lg/judyln/mba.mbn", "qcom/sdm845/lg/judyln/modem.mbn";
 };
 
 &pmi8998_charger {
@@ -137,9 +141,13 @@ sde_te_sleep: sde-te-sleep-state {
 };
 
 &bluetooth {
-		/*
-		 * This path is relative to the qca/
-		 * subdir under lib/firmware.
-		 */
-		firmware-name = "judyln/crnv21.bin";
+/*
+ * This path is relative to the qca/
+ * subdir under lib/firmware.
+ */
+	firmware-name = "judyln/crnv21.bin";
+};
+
+&venus {
+	firmware-name = "qcom/sdm845/lg/judyln/venus.mbn";
 };

-- 
2.51.0
Re: [PATCH v3 06/11] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
Posted by Dmitry Baryshkov 4 months, 1 week ago
On Sun, Sep 28, 2025 at 10:05:29PM -0700, Paul Sajna wrote:
> Add paths for Qualcomm firmware, including:
> ipa, modem, bluetooth, venus, gpu
> 
> Enable adsp and cdsp nodes since their firmware is present
> 
> GPU and bluetooth are confirmed working, others may need more
> testing/fixes
> 
> But regardless they will need the firmware paths specified here
> and firmware added upstream before they will work, so might as well
> get started on it now.
> 
> Paths changed to qcom/sdm845/lg/judyln
> 
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 10 ++++++++++
>  arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  | 26 +++++++++++++++++---------
>  2 files changed, 27 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index aa338612433f9ac3b07363b79d8a3b8e0eedd98b..0f0a3f471f48e26cc48feb1551093599fcb35d7f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -173,6 +173,10 @@ &adsp_pas {
>  	status = "okay";
>  };
>  
> +&cdsp_pas {
> +	status = "okay";
> +};

Please move it down. Also please check the order of other nodes in the
patch.

> +
> @@ -137,9 +141,13 @@ sde_te_sleep: sde-te-sleep-state {
>  };
>  
>  &bluetooth {
> -		/*
> -		 * This path is relative to the qca/
> -		 * subdir under lib/firmware.
> -		 */
> -		firmware-name = "judyln/crnv21.bin";
> +/*
> + * This path is relative to the qca/
> + * subdir under lib/firmware.
> + */

What happened? this should be a part of the earlier patch.

> +	firmware-name = "judyln/crnv21.bin";
> +};
> +
> +&venus {
> +	firmware-name = "qcom/sdm845/lg/judyln/venus.mbn";
>  };
> 
> -- 
> 2.51.0
> 

-- 
With best wishes
Dmitry