Hello maintainers,
This patch series fixes 18 errors and multiple warnings reported by
checkpatch.pl on drivers/i2c/algos/i2c-algo-pcf.c file.
The series PATCH v1 to PATCH v4 is a response to the discussion on the
mailing list with Markus Elfring who had comments on my earlier
submissions.
He suggested:
-to split my initial submission in a patch series
-had some valid points on imperative mood usage in commit messages
-wrapping commit message to 75 columns per line
-change some of the commit message to point usage of checkpatch.pl
The series PATCH v4 to PATCH v6 is a response to the discussion on the
mailing list with I2C SUBSYSTEM maintainer Wolfram Sang who requested
some changes:
He requested:
- to remove debug macros from i2c-algo-pcf.c as no code change was done
for almost 16 years.
- remove wrapping paranthesis from value assigned of '(0)''.
- resolve conficts caused by debug macros removal.
- remove also printk and dev_dbg function calls related to DEB macros.
Here is a brief summary and order of patches to be applied:
Patch 1/3: i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c
This patch remove the define of debug macros and also their usage from
code along with printk and dev_dbg function calls.
Patch 2/3: i2c: pcf8584: Fix do not use assignment inside if conditional
This patch takes the assignement from if conditional and moves it by 1 line
up.
Patch 3/3: i2c: pcf8584: Fix space(s) required before or after different
operators
This patch adds space(s) around some binary operators.
Testing:
*built kernel and modules with I2C_ALGOPCF=m and my 3 patches applied on
top of 6.17.0-rc7.
*installed kernel and external modules generated by build on my laptop
*rebooted and loaded i2c-algo-pcf.ko without i2c_debug parameter.
*when loading the .ko with i2c_debug parameter an error is seen in dmesg
and this is expected as the parameter was removed.
*No success message related to i2c_algo_pcf was seen in dmesg but also
no failures.
*Module loading and unloading successful.
*No PCF8584 Hardware was available.
Cezar Chiru (3):
i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c
i2c: pcf8584: Fix do not use assignment inside if conditional
i2c: pcf8584: Fix space(s) required before or after different
operators
drivers/i2c/algos/i2c-algo-pcf.c | 93 +++++++-------------------------
1 file changed, 18 insertions(+), 75 deletions(-)
--
2.43.0