arm64: dts: qcom: x1-dell-thena: Add missing pinctrl for eDP HPD

[PATCH] arm64: dts: qcom: x1-dell-thena: Add missing pinctrl for eDP HPD

Posted by Val Packett 4 days, 18 hours ago

Match the change for the XPS 13 (a41d2314) as the board is identical
between the XPS and the Latitude/Inspiron.

This allows us not to rely on the boot firmware to set up the pinctrl
for the eDP HPD line of the internal display.

Fixes: e7733b42111c ("arm64: dts: qcom: Add support for Dell Inspiron 7441 / Latitude 7455")
Signed-off-by: Val Packett <val@packett.cool>
---
 arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi b/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
index ef83e87e1b7a..0aad80a1159c 100644
--- a/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
@@ -1104,6 +1104,9 @@ &mdss_dp1_out {
 &mdss_dp3 {
 	/delete-property/ #sound-dai-cells;
 
+	pinctrl-0 = <&edp0_hpd_default>;
+	pinctrl-names = "default";
+
 	status = "okay";
 
 	aux-bus {
-- 
2.51.0

Re: [PATCH] arm64: dts: qcom: x1-dell-thena: Add missing pinctrl for eDP HPD

Posted by Bryan O'Donoghue 4 days, 12 hours ago

On 27/09/2025 04:23, Val Packett wrote:
> Match the change for the XPS 13 (a41d2314) as the board is identical
> between the XPS and the Latitude/Inspiron.

Same comment on the commit identification.

Also, are the boards identical ? I don't think that statement is true, 
say the "board DP here is identical" but there are GPIOs on the PCBs 
which read back different values to differentiate.

They are not identical PCBs.

> 
> This allows us not to rely on the boot firmware to set up the pinctrl
> for the eDP HPD line of the internal display.
> 
> Fixes: e7733b42111c ("arm64: dts: qcom: Add support for Dell Inspiron 7441 / Latitude 7455")
> Signed-off-by: Val Packett <val@packett.cool>
> ---
>   arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi b/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
> index ef83e87e1b7a..0aad80a1159c 100644
> --- a/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
> @@ -1104,6 +1104,9 @@ &mdss_dp1_out {
>   &mdss_dp3 {
>   	/delete-property/ #sound-dai-cells;
>   
> +	pinctrl-0 = <&edp0_hpd_default>;
> +	pinctrl-names = "default";
> +
>   	status = "okay";
>   
>   	aux-bus {

Once fixed.

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>