arm64: dts: qcom: qcs8300: pmic: Remove 'allow-set-time' property

[PATCH] arm64: dts: qcom: qcs8300: pmic: Remove 'allow-set-time' property

Posted by Tingguo Cheng 4 months, 2 weeks ago

Remove the 'allow-set-time' property from the rtc node because APPS
is prohibited from setting the hardware RTC time.

Signed-off-by: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/qcs8300-pmics.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300-pmics.dtsi b/arch/arm64/boot/dts/qcom/qcs8300-pmics.dtsi
index a94b0bfa98dc39e41d1a0de3373753953609b95c..e990d7367719beaa9e0cea87d9c183ae18c3ebc8 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs8300-pmics.dtsi
@@ -18,7 +18,6 @@ pmm8620au_0_rtc: rtc@6100 {
 			reg = <0x6100>, <0x6200>;
 			reg-names = "rtc", "alarm";
 			interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>;
-			allow-set-time;
 		};
 
 		pmm8620au_0_gpios: gpio@8800 {

---
base-commit: ca9c6709e594e040535540a41b89baf6437672ba
change-id: 20250926-remove-rtc-allow-set-time-ffbfa980930b

Best regards,
-- 
Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>

Re: [PATCH] arm64: dts: qcom: qcs8300: pmic: Remove 'allow-set-time' property

Posted by Bjorn Andersson 3 months, 1 week ago

On Fri, 26 Sep 2025 12:09:27 +0800, Tingguo Cheng wrote:
> Remove the 'allow-set-time' property from the rtc node because APPS
> is prohibited from setting the hardware RTC time.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: qcs8300: pmic: Remove 'allow-set-time' property
      commit: 4654433409914017618233daccfbf79876b2adfe

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] arm64: dts: qcom: qcs8300: pmic: Remove 'allow-set-time' property

Posted by Dmitry Baryshkov 4 months, 2 weeks ago

On Fri, Sep 26, 2025 at 12:09:27PM +0800, Tingguo Cheng wrote:
> Remove the 'allow-set-time' property from the rtc node because APPS
> is prohibited from setting the hardware RTC time.
> 
> Signed-off-by: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300-pmics.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-pmics.dtsi b/arch/arm64/boot/dts/qcom/qcs8300-pmics.dtsi
> index a94b0bfa98dc39e41d1a0de3373753953609b95c..e990d7367719beaa9e0cea87d9c183ae18c3ebc8 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-pmics.dtsi
> @@ -18,7 +18,6 @@ pmm8620au_0_rtc: rtc@6100 {
>  			reg = <0x6100>, <0x6200>;
>  			reg-names = "rtc", "alarm";
>  			interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>;
> -			allow-set-time;
>  		};
>  
>  		pmm8620au_0_gpios: gpio@8800 {

Do we have a UEFI variable or SDAM offset to keep the offset between the
RTC and HLOS then?

-- 
With best wishes
Dmitry

Re: [PATCH] arm64: dts: qcom: qcs8300: pmic: Remove 'allow-set-time' property

Posted by Konrad Dybcio 4 months, 2 weeks ago

On 9/26/25 6:09 AM, Tingguo Cheng wrote:
> Remove the 'allow-set-time' property from the rtc node because APPS
> is prohibited from setting the hardware RTC time.
> 
> Signed-off-by: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
> ---

nit: "qcs8300-pmics:" (like the file name)

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad