[v6] Add Network Subsystem (NSS) clock controller support for IPQ5424 SoC

[PATCH v6 02/10] dt-bindings: clock: Add "interconnect-cells" property in IPQ9574 example

Posted by Luo Jie 4 months, 2 weeks ago

The Networking Subsystem (NSS) clock controller acts as both a clock
provider and an interconnect provider. The #interconnect-cells property
is needed in the Device Tree Source (DTS) to ensure that client drivers
such as the PPE driver can correctly acquire ICC clocks from the NSS ICC
provider.

Add the #interconnect-cells property to the IPQ9574 Device Tree binding
example to complete it.

Fixes: 28300ecedce4 ("dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions")
Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
---
 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
index 17252b6ea3be..5d35925e60d0 100644
--- a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
@@ -94,5 +94,6 @@ examples:
                     "bus";
       #clock-cells = <1>;
       #reset-cells = <1>;
+      #interconnect-cells = <1>;
     };
 ...

-- 
2.34.1

Re: [PATCH v6 02/10] dt-bindings: clock: Add "interconnect-cells" property in IPQ9574 example

Posted by Rob Herring 4 months, 1 week ago

On Thu, Sep 25, 2025 at 10:05:36PM +0800, Luo Jie wrote:
> The Networking Subsystem (NSS) clock controller acts as both a clock
> provider and an interconnect provider. The #interconnect-cells property
> is needed in the Device Tree Source (DTS) to ensure that client drivers
> such as the PPE driver can correctly acquire ICC clocks from the NSS ICC
> provider.
> 
> Add the #interconnect-cells property to the IPQ9574 Device Tree binding
> example to complete it.

The subject is wrong as it #interconnect-cells, not interconnect-cells.

> 
> Fixes: 28300ecedce4 ("dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions")
> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
> ---
>  Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH v6 02/10] dt-bindings: clock: Add "interconnect-cells" property in IPQ9574 example

Posted by Luo Jie 4 months ago


On 10/2/2025 9:15 AM, Rob Herring wrote:
> On Thu, Sep 25, 2025 at 10:05:36PM +0800, Luo Jie wrote:
>> The Networking Subsystem (NSS) clock controller acts as both a clock
>> provider and an interconnect provider. The #interconnect-cells property
>> is needed in the Device Tree Source (DTS) to ensure that client drivers
>> such as the PPE driver can correctly acquire ICC clocks from the NSS ICC
>> provider.
>>
>> Add the #interconnect-cells property to the IPQ9574 Device Tree binding
>> example to complete it.
> 
> The subject is wrong as it #interconnect-cells, not interconnect-cells.

OK. I will update the subject to use #interconnect-cells as recommended.
Appreciate your review.

> 
>>
>> Fixes: 28300ecedce4 ("dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions")
>> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml | 1 +
>>   1 file changed, 1 insertion(+)
> 
> Acked-by: Rob Herring (Arm) <robh@kernel.org>