From: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Add missing space at end of comments and reformat to have uniform style.

Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
 drivers/tty/serial/sc16is7xx.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index 31d43fc857187..b3fbe9459303a 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -81,11 +81,14 @@
 /* IER register bits */
 #define SC16IS7XX_IER_RDI_BIT		BIT(0)   /* Enable RX data interrupt */
 #define SC16IS7XX_IER_THRI_BIT		BIT(1)   /* Enable TX holding register
-						  * interrupt */
+						  * interrupt
+						  */
 #define SC16IS7XX_IER_RLSI_BIT		BIT(2)   /* Enable RX line status
-						  * interrupt */
+						  * interrupt
+						  */
 #define SC16IS7XX_IER_MSI_BIT		BIT(3)   /* Enable Modem status
-						  * interrupt */
+						  * interrupt
+						  */
 
 /* IER register bits - write only if (EFR[4] == 1) */
 #define SC16IS7XX_IER_SLEEP_BIT		BIT(4)   /* Enable Sleep mode */
@@ -255,7 +258,8 @@
 
 /* EFCR register bits */
 #define SC16IS7XX_EFCR_9BIT_MODE_BIT	BIT(0)   /* Enable 9-bit or Multidrop
-						  * mode (RS485) */
+						  * mode (RS485)
+						  */
 #define SC16IS7XX_EFCR_RXDISABLE_BIT	BIT(1)   /* Disable receiver */
 #define SC16IS7XX_EFCR_TXDISABLE_BIT	BIT(2)   /* Disable transmitter */
 #define SC16IS7XX_EFCR_AUTO_RS485_BIT	BIT(4)   /* Auto RS485 RTS direction */
@@ -1152,7 +1156,7 @@ static int sc16is7xx_startup(struct uart_port *port)
 
 	sc16is7xx_power(port, 1);
 
-	/* Reset FIFOs*/
+	/* Reset FIFOs */
 	val = SC16IS7XX_FCR_RXRESET_BIT | SC16IS7XX_FCR_TXRESET_BIT;
 	sc16is7xx_port_write(port, SC16IS7XX_FCR_REG, val);
 	udelay(5);
-- 
2.39.5

On 24. 09. 25, 17:37, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> 
> Add missing space at end of comments and reformat to have uniform style.
> 
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
>   drivers/tty/serial/sc16is7xx.c | 14 +++++++++-----
>   1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 31d43fc857187..b3fbe9459303a 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -81,11 +81,14 @@
>   /* IER register bits */
>   #define SC16IS7XX_IER_RDI_BIT		BIT(0)   /* Enable RX data interrupt */
>   #define SC16IS7XX_IER_THRI_BIT		BIT(1)   /* Enable TX holding register
> -						  * interrupt */
> +						  * interrupt
> +						  */

I am not forcing this, but maybe put it on one line, if it fits into 100 
columns? I believe people are using 100 columns nowadays (me included).


-- 
js
suse labs

Hi Jiri,

On Mon, 29 Sep 2025 08:18:01 +0200
Jiri Slaby <jirislaby@kernel.org> wrote:

> On 24. 09. 25, 17:37, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > 
> > Add missing space at end of comments and reformat to have uniform style.
> > 
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > ---
> >   drivers/tty/serial/sc16is7xx.c | 14 +++++++++-----
> >   1 file changed, 9 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> > index 31d43fc857187..b3fbe9459303a 100644
> > --- a/drivers/tty/serial/sc16is7xx.c
> > +++ b/drivers/tty/serial/sc16is7xx.c
> > @@ -81,11 +81,14 @@
> >   /* IER register bits */
> >   #define SC16IS7XX_IER_RDI_BIT		BIT(0)   /* Enable RX data interrupt */
> >   #define SC16IS7XX_IER_THRI_BIT		BIT(1)   /* Enable TX holding register
> > -						  * interrupt */
> > +						  * interrupt
> > +						  */
> 
> I am not forcing this, but maybe put it on one line, if it fits into 100 
> columns? I believe people are using 100 columns nowadays (me included).

Yes good idea. And since the goal of this commit was to try to
uniformize all comments accross the driver, I will probably reformat
most of them to improve readability and follow same convention.

Hugo.

-- 
Hugo Villeneuve