[v1] serial: sc16is7xx: register access fixes and improvements

[PATCH 11/15] serial: sc16is7xx: remove empty line

Posted by Hugo Villeneuve 2 months, 3 weeks ago

From: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Remove empty line inavertently added in commit d5078509c8b0
("serial: sc16is7xx: improve do/while loop in sc16is7xx_irq()").

Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
 drivers/tty/serial/sc16is7xx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index d1a9fa26e9bdb..a05be92f7e776 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -834,7 +834,6 @@ static bool sc16is7xx_port_irq(struct sc16is7xx_port *s, int portno)
 static irqreturn_t sc16is7xx_irq(int irq, void *dev_id)
 {
 	bool keep_polling;
-
 	struct sc16is7xx_port *s = (struct sc16is7xx_port *)dev_id;
 
 	do {
-- 
2.39.5

Re: [PATCH 11/15] serial: sc16is7xx: remove empty line

Posted by Jiri Slaby 2 months, 2 weeks ago

On 24. 09. 25, 17:37, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> 
> Remove empty line inavertently added in commit d5078509c8b0
> ("serial: sc16is7xx: improve do/while loop in sc16is7xx_irq()").
> 
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
>   drivers/tty/serial/sc16is7xx.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index d1a9fa26e9bdb..a05be92f7e776 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -834,7 +834,6 @@ static bool sc16is7xx_port_irq(struct sc16is7xx_port *s, int portno)
>   static irqreturn_t sc16is7xx_irq(int irq, void *dev_id)
>   {
>   	bool keep_polling;
> -
>   	struct sc16is7xx_port *s = (struct sc16is7xx_port *)dev_id;

And remove the cast and switch the two definitions, so we have a 
reversed xmas tree ;).

>   	do {


-- 
js
suse labs

Re: [PATCH 11/15] serial: sc16is7xx: remove empty line

Posted by Hugo Villeneuve 2 months, 2 weeks ago

Hi Jiri,

On Mon, 29 Sep 2025 08:14:33 +0200
Jiri Slaby <jirislaby@kernel.org> wrote:

> On 24. 09. 25, 17:37, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > 
> > Remove empty line inavertently added in commit d5078509c8b0
> > ("serial: sc16is7xx: improve do/while loop in sc16is7xx_irq()").
> > 
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > ---
> >   drivers/tty/serial/sc16is7xx.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> > index d1a9fa26e9bdb..a05be92f7e776 100644
> > --- a/drivers/tty/serial/sc16is7xx.c
> > +++ b/drivers/tty/serial/sc16is7xx.c
> > @@ -834,7 +834,6 @@ static bool sc16is7xx_port_irq(struct sc16is7xx_port *s, int portno)
> >   static irqreturn_t sc16is7xx_irq(int irq, void *dev_id)
> >   {
> >   	bool keep_polling;
> > -
> >   	struct sc16is7xx_port *s = (struct sc16is7xx_port *)dev_id;
> 
> And remove the cast and switch the two definitions, so we have a 
> reversed xmas tree ;).

Good idea, I will do it in V2.

Hugo.