[PATCH v2 06/16] property: Drop DEVICE_DISABLED flag in fwnode_graph_get_endpoint_by_id()

Sakari Ailus posted 16 patches 1 week ago
[PATCH v2 06/16] property: Drop DEVICE_DISABLED flag in fwnode_graph_get_endpoint_by_id()
Posted by Sakari Ailus 1 week ago
No caller uses FWNODE_GRAPH_DEVICE_DISABLED flag when calling
fwnode_graph_get_endpoint_by_id(). Drop support for the flag entirely and
remove it from the documentation.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/base/property.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/base/property.c b/drivers/base/property.c
index b52f7b3bbf84..7fc3257f223d 100644
--- a/drivers/base/property.c
+++ b/drivers/base/property.c
@@ -1239,9 +1239,6 @@ static bool fwnode_graph_remote_available(struct fwnode_handle *ep)
  * has not been found, look for the closest endpoint ID greater than the
  * specified one and return the endpoint that corresponds to it, if present.
  *
- * Does not return endpoints that belong to disabled devices or endpoints that
- * are unconnected, unless FWNODE_GRAPH_DEVICE_DISABLED is passed in @flags.
- *
  * Return: the fwnode handle of the local endpoint corresponding the port and
  * endpoint IDs or %NULL if not found.
  */
@@ -1252,13 +1249,12 @@ fwnode_graph_get_endpoint_by_id(const struct fwnode_handle *fwnode,
 	struct fwnode_handle *ep, *best_ep = NULL;
 	unsigned int best_ep_id = 0;
 	bool endpoint_next = flags & FWNODE_GRAPH_ENDPOINT_NEXT;
-	bool enabled_only = !(flags & FWNODE_GRAPH_DEVICE_DISABLED);
 
 	fwnode_graph_for_each_endpoint(fwnode, ep) {
 		struct fwnode_endpoint fwnode_ep = { 0 };
 		int ret;
 
-		if (enabled_only && !fwnode_graph_remote_available(ep))
+		if (!fwnode_graph_remote_available(ep))
 			continue;
 
 		ret = fwnode_graph_parse_endpoint(ep, &fwnode_ep);
-- 
2.47.3
Re: [PATCH v2 06/16] property: Drop DEVICE_DISABLED flag in fwnode_graph_get_endpoint_by_id()
Posted by Laurent Pinchart 1 week ago
Hi Sakari,

Thank you for the patch.

On Wed, Sep 24, 2025 at 10:45:52AM +0300, Sakari Ailus wrote:
> No caller uses FWNODE_GRAPH_DEVICE_DISABLED flag when calling
> fwnode_graph_get_endpoint_by_id(). Drop support for the flag entirely and
> remove it from the documentation.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

You can squash this with 07/16.

> ---
>  drivers/base/property.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index b52f7b3bbf84..7fc3257f223d 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -1239,9 +1239,6 @@ static bool fwnode_graph_remote_available(struct fwnode_handle *ep)
>   * has not been found, look for the closest endpoint ID greater than the
>   * specified one and return the endpoint that corresponds to it, if present.
>   *
> - * Does not return endpoints that belong to disabled devices or endpoints that
> - * are unconnected, unless FWNODE_GRAPH_DEVICE_DISABLED is passed in @flags.
> - *
>   * Return: the fwnode handle of the local endpoint corresponding the port and
>   * endpoint IDs or %NULL if not found.
>   */
> @@ -1252,13 +1249,12 @@ fwnode_graph_get_endpoint_by_id(const struct fwnode_handle *fwnode,
>  	struct fwnode_handle *ep, *best_ep = NULL;
>  	unsigned int best_ep_id = 0;
>  	bool endpoint_next = flags & FWNODE_GRAPH_ENDPOINT_NEXT;
> -	bool enabled_only = !(flags & FWNODE_GRAPH_DEVICE_DISABLED);
>  
>  	fwnode_graph_for_each_endpoint(fwnode, ep) {
>  		struct fwnode_endpoint fwnode_ep = { 0 };
>  		int ret;
>  
> -		if (enabled_only && !fwnode_graph_remote_available(ep))
> +		if (!fwnode_graph_remote_available(ep))
>  			continue;
>  
>  		ret = fwnode_graph_parse_endpoint(ep, &fwnode_ep);

-- 
Regards,

Laurent Pinchart