[PATCH RESEND v6 0/4] stratix10: Add framework for asynchronous communication with SDM

Mahesh Rao via B4 Relay posted 4 patches 4 months, 2 weeks ago
There is a newer version of this series
drivers/firmware/stratix10-rsu.c                   | 272 ++++----
drivers/firmware/stratix10-svc.c                   | 739 ++++++++++++++++++++-
include/linux/firmware/intel/stratix10-smc.h       |  76 +++
.../linux/firmware/intel/stratix10-svc-client.h    |  92 +++
4 files changed, 1045 insertions(+), 134 deletions(-)
[PATCH RESEND v6 0/4] stratix10: Add framework for asynchronous communication with SDM
Posted by Mahesh Rao via B4 Relay 4 months, 2 weeks ago
The patch set includes the following changes:

- Add protection for querying memory objects in multi-threaded flow.
- Add support to generate and maintain message id and client id for
  asynchronous communication with SDM.
- Add framework to communicate with Secure Device Manager (SDM)
  asynchronously by sending a request and polling for response.
- Add commands for performing Remote System Update (RSU) operations
  asynchronously.
- Migrate RSU driver to use the asynchronous communication framework.

---
- Link to v6: https://lore.kernel.org/r/20250901-sip_svc_upstream-v6-0-b4db7f07cbb2@altera.com

Changes in v6:
- Use guard() helper function for svc_mem_lock.
- Fixed comment message style according to kernel coding style.
- Added fixes tag to commit message.
- Removed id generation patch and use in house ida allocator.
- Changed lock of hashmap db lock from rcu to spinlock for better latency.

- Link to v5: https://lore.kernel.org/r/20250708-sip_svc_upstream-v5-0-9c4289256d54@altera.com

- Link to v5: https://lore.kernel.org/r/20250620-sip_svc_upstream-v5-0-732d4ac08a32@altera.com

Changes in v5:
- Use FIELD_PREP, FIELD_GET() and GENMASK() for bit
  manipulation for ids.
- Bring down probing when stratix10_svc_async_init()
  fails.
- Other minor fixes.

- Link to v4: https://lore.kernel.org/r/20250610-sip_svc_upstream-v4-0-bcd9d6089071@altera.com

Changes in v4:
- Added description for svc_mem_lock mutex.
- Wrapped commit message and comments in source
  code to kernel coding style as per coding style.
- Added minor code fixes.
- Moved variables to the top of the function
- Removed HWMON support from in the patch-set, this
  will be sent in a separate patch-set.
- Added support for RSU commands to asynchronously
  communicate with SDM.
- Migrated RSU driver to use the supported 
  asynchronous commands.

- Link to v3: https://lore.kernel.org/r/20250526-sip_svc_upstream-v3-0-6a08a4502de3@altera.com

Changes in v3:
- Changed "Stratix 10" to "Stratix10" in the commit
  message and in source code.
- Simplified stratix10_svc_add_async_client() by removing
  redundant code for async common channel initialization.
- Fixed resource cleanup on negative path in
  stratix10_svc_remove_async_client() and stratix10_svc_async_init().
- Removed optional interrupt handler support, will send the patches
  in a separate patch-set.

- Link to v2: https://lore.kernel.org/r/20250512-sip_svc_upstream-v2-0-fae5c45c059d@altera.com

Changes in v2:
- Added Reviewed by tag from Rob Herring for dt-binding
  patch.
- Resending the patch-set as there is no response from
  the maintainers for the previous patch submission.

- Link to v1: https://lore.kernel.org/r/20250422-sip_svc_upstream-v1-0-088059190f31@altera.com

---
Mahesh Rao (4):
      firmware: stratix10-svc: Add mutex in stratix10 memory management
      firmware: stratix10-svc: Add support for async communication
      firmware: stratix10-svc: Add support for RSU commands in asynchronous framework
      firmware: stratix10-rsu: Migrate RSU driver to use stratix10 asynchronous framework.

 drivers/firmware/stratix10-rsu.c                   | 272 ++++----
 drivers/firmware/stratix10-svc.c                   | 739 ++++++++++++++++++++-
 include/linux/firmware/intel/stratix10-smc.h       |  76 +++
 .../linux/firmware/intel/stratix10-svc-client.h    |  92 +++
 4 files changed, 1045 insertions(+), 134 deletions(-)
---
base-commit: 5cc61f86dff464a63b6a6e4758f26557fda4d494
change-id: 20250131-sip_svc_upstream-e78d8c9b4335

Best regards,
-- 
Mahesh Rao <mahesh.rao@altera.com>
Re: [PATCH RESEND v6 0/4] stratix10: Add framework for asynchronous communication with SDM
Posted by Dinh Nguyen 3 months, 2 weeks ago

On 9/24/25 02:39, Mahesh Rao via B4 Relay wrote:
> The patch set includes the following changes:
> 
> - Add protection for querying memory objects in multi-threaded flow.
> - Add support to generate and maintain message id and client id for
>    asynchronous communication with SDM.
> - Add framework to communicate with Secure Device Manager (SDM)
>    asynchronously by sending a request and polling for response.
> - Add commands for performing Remote System Update (RSU) operations
>    asynchronously.
> - Migrate RSU driver to use the asynchronous communication framework.
> 
> ---
> - Link to v6: https://lore.kernel.org/r/20250901-sip_svc_upstream-v6-0-b4db7f07cbb2@altera.com
> 
> Changes in v6:
> - Use guard() helper function for svc_mem_lock.
> - Fixed comment message style according to kernel coding style.
> - Added fixes tag to commit message.
> - Removed id generation patch and use in house ida allocator.
> - Changed lock of hashmap db lock from rcu to spinlock for better latency.
> 
> - Link to v5: https://lore.kernel.org/r/20250708-sip_svc_upstream-v5-0-9c4289256d54@altera.com
> 
> - Link to v5: https://lore.kernel.org/r/20250620-sip_svc_upstream-v5-0-732d4ac08a32@altera.com
> 
> Changes in v5:
> - Use FIELD_PREP, FIELD_GET() and GENMASK() for bit
>    manipulation for ids.
> - Bring down probing when stratix10_svc_async_init()
>    fails.
> - Other minor fixes.
> 
> - Link to v4: https://lore.kernel.org/r/20250610-sip_svc_upstream-v4-0-bcd9d6089071@altera.com
> 
> Changes in v4:
> - Added description for svc_mem_lock mutex.
> - Wrapped commit message and comments in source
>    code to kernel coding style as per coding style.
> - Added minor code fixes.
> - Moved variables to the top of the function
> - Removed HWMON support from in the patch-set, this
>    will be sent in a separate patch-set.
> - Added support for RSU commands to asynchronously
>    communicate with SDM.
> - Migrated RSU driver to use the supported
>    asynchronous commands

Can you please rebase this series on my latest tree:

https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=svc_driver_for_v6.19

Patch 2 is not applying correctly.

Thanks,
Dinh
Re: [PATCH RESEND v6 0/4] stratix10: Add framework for asynchronous communication with SDM
Posted by Mahesh Rao 3 months, 1 week ago
Hi Dinh,

On 20-10-2025 09:33 pm, Dinh Nguyen wrote:
> 
> 
> On 9/24/25 02:39, Mahesh Rao via B4 Relay wrote:
>> The patch set includes the following changes:
>>
>> - Add protection for querying memory objects in multi-threaded flow.
>> - Add support to generate and maintain message id and client id for
>>    asynchronous communication with SDM.
>> - Add framework to communicate with Secure Device Manager (SDM)
>>    asynchronously by sending a request and polling for response.
>> - Add commands for performing Remote System Update (RSU) operations
>>    asynchronously.
>> - Migrate RSU driver to use the asynchronous communication framework.
>>
>> ---
>> - Link to v6: https://lore.kernel.org/r/20250901-sip_svc_upstream- 
>> v6-0-b4db7f07cbb2@altera.com
>>
>> Changes in v6:


>> - Added support for RSU commands to asynchronously
>>    communicate with SDM.
>> - Migrated RSU driver to use the supported
>>    asynchronous commands
> 
> Can you please rebase this series on my latest tree:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/? 
> h=svc_driver_for_v6.19
> 
> Patch 2 is not applying correctly.

Sorry for the delayed response, as I was on vacation last week.

Sure, I will rebase the patchset onto svc_driver_for_v6.19 and re share.

> 
> Thanks,
> Dinh