[v2] platform/x86: acer-wmi: Add fan control support

[PATCH v2 0/4] platform/x86: acer-wmi: Add fan control support

Posted by Armin Wolf 1 week, 1 day ago

This patch series aims to add fan control support to the acer-wmi
driver. The patches are compile-tested only and need to be tested
on real hardware to verify that they actually work.

I CCed three users who requested support for this feature. I would be
very happy if one of you could test those patches and report back.

Changes since v1:
- remove unnecessary blank line

Changes since RFC v2:
- improve error handling when setting fan behavior
- Add Reviewed-by tags
- whitelist PHN16-72

Changes since RFC v1:
- remove duplicate include and replace hwmon_pwm_mode with
  hwmon_pwm_enable in second patch

Armin Wolf (4):
  platform/x86: acer-wmi: Fix setting of fan behavior
  platform/x86: acer-wmi: Add fan control support
  platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
  platform/x86: acer-wmi: Add support for PHN16-72

 drivers/platform/x86/acer-wmi.c | 308 +++++++++++++++++++++++++++++---
 1 file changed, 283 insertions(+), 25 deletions(-)

-- 
2.39.5

Re: [PATCH v2 0/4] platform/x86: acer-wmi: Add fan control support

Posted by Fa-Iz Faadhillah Ibrahim 2 days, 22 hours ago

On Wednesday, September 24, 2025 4:52 AM Armin Wolf wrote:
> This patch series aims to add fan control support to the acer-wmi
> driver. The patches are compile-tested only and need to be tested
> on real hardware to verify that they actually work.
> 
> I CCed three users who requested support for this feature. I would be
> very happy if one of you could test those patches and report back.
> 
> Changes since v1:
> - remove unnecessary blank line
> 
> Changes since RFC v2:
> - improve error handling when setting fan behavior
> - Add Reviewed-by tags
> - whitelist PHN16-72
> 
> Changes since RFC v1:
> - remove duplicate include and replace hwmon_pwm_mode with
>   hwmon_pwm_enable in second patch
> 
> Armin Wolf (4):
>   platform/x86: acer-wmi: Fix setting of fan behavior
>   platform/x86: acer-wmi: Add fan control support
>   platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
>   platform/x86: acer-wmi: Add support for PHN16-72
> 
>  drivers/platform/x86/acer-wmi.c | 308 +++++++++++++++++++++++++++++---
>  1 file changed, 283 insertions(+), 25 deletions(-)

Hi,

I've tested your patch on my PHN16-72, Fan control works just fine, and it does 
detect my laptop properly.

Thanks,
Fa-Iz Faadhillah Ibrahim