While converting the hifsys to YAML schema, the "syscon" compatible was
dropped for the mt7623 and the mt2701 compatible.
Add back the compatible to mute DTBs warning on "make dtbs_check" and
reflect real state of the .dtsi.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
.../devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml
index 9e7c725093aa..aa3345ea8283 100644
--- a/Documentation/devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml
+++ b/Documentation/devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml
@@ -16,13 +16,15 @@ maintainers:
properties:
compatible:
oneOf:
- - enum:
- - mediatek,mt2701-hifsys
- - mediatek,mt7622-hifsys
+ - items:
+ - const: mediatek,mt2701-hifsys
+ - const: syscon
+ - const: mediatek,mt7622-hifsys
- items:
- enum:
- mediatek,mt7623-hifsys
- const: mediatek,mt2701-hifsys
+ - const: syscon
reg:
maxItems: 1
--
2.51.0On Tue, Sep 23, 2025 at 10:12:29PM +0200, Christian Marangi wrote: > While converting the hifsys to YAML schema, the "syscon" compatible was > dropped for the mt7623 and the mt2701 compatible. Is "syscon" really needed? AFAICT, the clock and reset drivers don't need it. > > Add back the compatible to mute DTBs warning on "make dtbs_check" and > reflect real state of the .dtsi. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > .../devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml > index 9e7c725093aa..aa3345ea8283 100644 > --- a/Documentation/devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml > +++ b/Documentation/devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml > @@ -16,13 +16,15 @@ maintainers: > properties: > compatible: > oneOf: > - - enum: > - - mediatek,mt2701-hifsys > - - mediatek,mt7622-hifsys > + - items: > + - const: mediatek,mt2701-hifsys > + - const: syscon > + - const: mediatek,mt7622-hifsys > - items: > - enum: > - mediatek,mt7623-hifsys > - const: mediatek,mt2701-hifsys > + - const: syscon > > reg: > maxItems: 1 > -- > 2.51.0 >
On Wed, Sep 24, 2025 at 09:03:47AM -0500, Rob Herring wrote: > On Tue, Sep 23, 2025 at 10:12:29PM +0200, Christian Marangi wrote: > > While converting the hifsys to YAML schema, the "syscon" compatible was > > dropped for the mt7623 and the mt2701 compatible. > > Is "syscon" really needed? AFAICT, the clock and reset drivers don't > need it. > Ok I also searched downstream and can't find any patch that would make use of syscon. Guess I will replace this patch with a patch that drop the syscon from the dts. > > > > Add back the compatible to mute DTBs warning on "make dtbs_check" and > > reflect real state of the .dtsi. > > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > --- > > .../devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml > > index 9e7c725093aa..aa3345ea8283 100644 > > --- a/Documentation/devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml > > +++ b/Documentation/devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml > > @@ -16,13 +16,15 @@ maintainers: > > properties: > > compatible: > > oneOf: > > - - enum: > > - - mediatek,mt2701-hifsys > > - - mediatek,mt7622-hifsys > > + - items: > > + - const: mediatek,mt2701-hifsys > > + - const: syscon > > + - const: mediatek,mt7622-hifsys > > - items: > > - enum: > > - mediatek,mt7623-hifsys > > - const: mediatek,mt2701-hifsys > > + - const: syscon > > > > reg: > > maxItems: 1 > > -- > > 2.51.0 > > -- Ansuel
On Tue, 23 Sep 2025 22:12:29 +0200, Christian Marangi wrote: > While converting the hifsys to YAML schema, the "syscon" compatible was > dropped for the mt7623 and the mt2701 compatible. > > Add back the compatible to mute DTBs warning on "make dtbs_check" and > reflect real state of the .dtsi. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > .../devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/mediatek,mt2701-hifsys.example.dtb: clock-controller@1a000000 (mediatek,mt2701-hifsys): compatible: 'oneOf' conditional failed, one must be fixed: ['mediatek,mt2701-hifsys'] is too short 'mediatek,mt7622-hifsys' was expected 'mediatek,mt2701-hifsys' is not one of ['mediatek,mt7623-hifsys'] from schema $id: http://devicetree.org/schemas/clock/mediatek,mt2701-hifsys.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250923201244.952-2-ansuelsmth@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
© 2016 - 2025 Red Hat, Inc.