[PATCH] media: saa6588: Fix unsafe debug printk macro

Shrikant Raskar posted 1 patch 1 week, 1 day ago
drivers/media/i2c/saa6588.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] media: saa6588: Fix unsafe debug printk macro
Posted by Shrikant Raskar 1 week, 1 day ago
The existing dprintk macro used an unwrapped `if` statement, which can lead
to logic errors when used in if/else constructs. This patch wraps the macro
in a do { } while (0) block to ensure safe usage.

This change resolves the following checkpatch error:
ERROR: Macros starting with if should be enclosed by a do - while loop to
avoid possible if/else logic defects

Signed-off-by: Shrikant Raskar <raskar.shree97@gmail.com>
---
 drivers/media/i2c/saa6588.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/saa6588.c b/drivers/media/i2c/saa6588.c
index fb09e4560d8a..71d34d229564 100644
--- a/drivers/media/i2c/saa6588.c
+++ b/drivers/media/i2c/saa6588.c
@@ -50,7 +50,7 @@ MODULE_LICENSE("GPL");
 
 #define UNSET       (-1U)
 #define PREFIX      "saa6588: "
-#define dprintk     if (debug) printk
+#define dprintk(fmt, args...)  do { if (debug) printk(fmt, ##args); } while (0)
 
 struct saa6588 {
 	struct v4l2_subdev sd;
-- 
2.43.0