[v1] powerpc/smp: Add check for kcalloc() in parse_thread_groups()

[PATCH] powerpc/smp: Add check for kcalloc() in parse_thread_groups()

Guangshuo Li posted 1 patch 1 week, 2 days ago

Diff against v1 v1
Download mbox

arch/powerpc/kernel/smp.c | 3 +++
1 file changed, 3 insertions(+)

Expand all Fold all

[PATCH] powerpc/smp: Add check for kcalloc() in parse_thread_groups()

Posted by Guangshuo Li 1 week, 2 days ago

As kcalloc() may fail, check its return value to avoid a NULL pointer
dereference when passing it to of_property_read_u32_array().

Fixes: 790a1662d3a26 ("powerpc/smp: Parse ibm,thread-groups with multiple properties")
Cc: stable@vger.kernel.org
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
---
 arch/powerpc/kernel/smp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 5ac7084eebc0..2da064e00d0d 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -822,6 +822,9 @@ static int parse_thread_groups(struct device_node *dn,
 
 	count = of_property_count_u32_elems(dn, "ibm,thread-groups");
 	thread_group_array = kcalloc(count, sizeof(u32), GFP_KERNEL);
+	if (!thread_group_array)
+		return -ENOMEM;
+
 	ret = of_property_read_u32_array(dn, "ibm,thread-groups",
 					 thread_group_array, count);
 	if (ret)
-- 
2.43.0