[PATCH v4 0/4] Add Aspeed AST2700 uhci support

Ryan Chen posted 4 patches 1 week, 2 days ago
.../devicetree/bindings/usb/usb-uhci.yaml     | 13 ++++++++
drivers/usb/host/uhci-hcd.h                   |  1 +
drivers/usb/host/uhci-platform.c              | 31 ++++++++++++++++---
3 files changed, 41 insertions(+), 4 deletions(-)
[PATCH v4 0/4] Add Aspeed AST2700 uhci support
Posted by Ryan Chen 1 week, 2 days ago
This patch series adds support for the UHCI controller found on the
Aspeed AST2700 SoC.

Compared to earlier SoCs (AST2400/2500/2600), AST2700 UHCI:
 - requires a reset line to be deasserted before use
 - supports 64-bit DMA addressing

This series updates the bindings and platform driver accordingly.

v4:
- usb-uhci.yaml
 - fix errors 'make dt_binding_check'
- uhci-platform.c
 - remove IS_ERR_OR_NULL(uhci->rsts) check, due to reset_control_assert
   will return 0, when uhci->rsts is null.
 - use dma_mask_32 as default, and just add aspeed,ast2700-uhci for dma_64.

v3:
- uhci-platform.c
 - add reset_control_assert in uhci_hcd_platform_remove.

v2:
- usb-uhci.yaml
 - add required resets for aspeed,ast2700-uhci
- uhci-platform.c
 - change the err_clk before err_reset.

Ryan Chen (4):
  dt-bindings: usb: uhci: Add reset property
  usb: uhci: Add reset control support
  dt-bindings: usb: uhci: Add Aspeed AST2700 compatible
  usb: uhci: Add Aspeed AST2700 support

 .../devicetree/bindings/usb/usb-uhci.yaml     | 13 ++++++++
 drivers/usb/host/uhci-hcd.h                   |  1 +
 drivers/usb/host/uhci-platform.c              | 31 ++++++++++++++++---
 3 files changed, 41 insertions(+), 4 deletions(-)

-- 
2.34.1
Re: [PATCH v4 0/4] Add Aspeed AST2700 uhci support
Posted by Alan Stern 1 week, 2 days ago
On Mon, Sep 22, 2025 at 01:20:41PM +0800, Ryan Chen wrote:
> This patch series adds support for the UHCI controller found on the
> Aspeed AST2700 SoC.
> 
> Compared to earlier SoCs (AST2400/2500/2600), AST2700 UHCI:
>  - requires a reset line to be deasserted before use
>  - supports 64-bit DMA addressing
> 
> This series updates the bindings and platform driver accordingly.

For patches 2/4 and 4/4:

Reviewed-by: Alan Stern <stern@rowland.harvard.edu>

Alan Stern

> v4:
> - usb-uhci.yaml
>  - fix errors 'make dt_binding_check'
> - uhci-platform.c
>  - remove IS_ERR_OR_NULL(uhci->rsts) check, due to reset_control_assert
>    will return 0, when uhci->rsts is null.
>  - use dma_mask_32 as default, and just add aspeed,ast2700-uhci for dma_64.
> 
> v3:
> - uhci-platform.c
>  - add reset_control_assert in uhci_hcd_platform_remove.
> 
> v2:
> - usb-uhci.yaml
>  - add required resets for aspeed,ast2700-uhci
> - uhci-platform.c
>  - change the err_clk before err_reset.
> 
> Ryan Chen (4):
>   dt-bindings: usb: uhci: Add reset property
>   usb: uhci: Add reset control support
>   dt-bindings: usb: uhci: Add Aspeed AST2700 compatible
>   usb: uhci: Add Aspeed AST2700 support
> 
>  .../devicetree/bindings/usb/usb-uhci.yaml     | 13 ++++++++
>  drivers/usb/host/uhci-hcd.h                   |  1 +
>  drivers/usb/host/uhci-platform.c              | 31 ++++++++++++++++---
>  3 files changed, 41 insertions(+), 4 deletions(-)
> 
> -- 
> 2.34.1
>