gpio: rework debug macros

[PATCH 0/4] gpio: rework debug macros

Posted by Bartosz Golaszewski 4 months, 2 weeks ago

Rename the chip_$level() macros to gpiochip_$level() and reuse some code
in macro definitions.

No functional change.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Bartosz Golaszewski (4):
      gpiolib: remove unnecessary 'out of memory' messages
      gpiolib: rename GPIO chip printk macros
      gpiolib: reuse macro code in GPIO descriptor printk helpers
      gpiolib: reuse macro code in GPIO chip printk helpers

 drivers/gpio/gpiolib-cdev.c  |  2 +-
 drivers/gpio/gpiolib-sysfs.c |  2 +-
 drivers/gpio/gpiolib.c       | 88 +++++++++++++++++++++-----------------------
 drivers/gpio/gpiolib.h       | 41 ++++++++-------------
 4 files changed, 58 insertions(+), 75 deletions(-)
---
base-commit: 846bd2225ec3cfa8be046655e02b9457ed41973e
change-id: 20250922-gpio-debug-macros-d37201504cdf

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH 0/4] gpio: rework debug macros

Posted by Bartosz Golaszewski 3 months, 4 weeks ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Mon, 22 Sep 2025 11:54:01 +0200, Bartosz Golaszewski wrote:
> Rename the chip_$level() macros to gpiochip_$level() and reuse some code
> in macro definitions.
> 
> No functional change.
> 
> 

Applied, thanks!

[1/4] gpiolib: remove unnecessary 'out of memory' messages
      https://git.kernel.org/brgl/linux/c/0ba6f1ed3808b1f095fbdb490006f0ecd00f52bd
[2/4] gpiolib: rename GPIO chip printk macros
      https://git.kernel.org/brgl/linux/c/d4f335b410ddbe3e99f48f8b5ea78a25041274f1
[3/4] gpiolib: reuse macro code in GPIO descriptor printk helpers
      https://git.kernel.org/brgl/linux/c/3f0be1783a8ff57f77e6f9a12621903b5a496d40
[4/4] gpiolib: reuse macro code in GPIO chip printk helpers
      https://git.kernel.org/brgl/linux/c/1540b799d271b545bf04726906184bdf29ab272b

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH 0/4] gpio: rework debug macros

Posted by Linus Walleij 4 months, 1 week ago

On Mon, Sep 22, 2025 at 11:54 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> Rename the chip_$level() macros to gpiochip_$level() and reuse some code
> in macro definitions.
>
> No functional change.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

This LGTM!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij