gpio: rework debug macros

[PATCH 0/4] gpio: rework debug macros

Bartosz Golaszewski posted 4 patches 1 week, 2 days ago

Download series mbox

drivers/gpio/gpiolib-cdev.c  |  2 +-
drivers/gpio/gpiolib-sysfs.c |  2 +-
drivers/gpio/gpiolib.c       | 88 +++++++++++++++++++++-----------------------
drivers/gpio/gpiolib.h       | 41 ++++++++-------------
4 files changed, 58 insertions(+), 75 deletions(-)

Expand all Fold all

[PATCH 0/4] gpio: rework debug macros

Posted by Bartosz Golaszewski 1 week, 2 days ago

Rename the chip_$level() macros to gpiochip_$level() and reuse some code
in macro definitions.

No functional change.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Bartosz Golaszewski (4):
      gpiolib: remove unnecessary 'out of memory' messages
      gpiolib: rename GPIO chip printk macros
      gpiolib: reuse macro code in GPIO descriptor printk helpers
      gpiolib: reuse macro code in GPIO chip printk helpers

 drivers/gpio/gpiolib-cdev.c  |  2 +-
 drivers/gpio/gpiolib-sysfs.c |  2 +-
 drivers/gpio/gpiolib.c       | 88 +++++++++++++++++++++-----------------------
 drivers/gpio/gpiolib.h       | 41 ++++++++-------------
 4 files changed, 58 insertions(+), 75 deletions(-)
---
base-commit: 846bd2225ec3cfa8be046655e02b9457ed41973e
change-id: 20250922-gpio-debug-macros-d37201504cdf

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH 0/4] gpio: rework debug macros

Posted by Linus Walleij 20 hours ago

On Mon, Sep 22, 2025 at 11:54 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> Rename the chip_$level() macros to gpiochip_$level() and reuse some code
> in macro definitions.
>
> No functional change.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

This LGTM!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij