[v1] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins

[PATCH] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins

Posted by Eric Gonçalves 4 months, 2 weeks ago

The S20 series has additional reserved pins for the fingerprint sensor,
GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.

Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
---
 arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
index 96662bf9e527..1680be67e733 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
@@ -159,7 +159,8 @@ &pon_resin {
 };
 
 &tlmm {
-	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
+	gpio-reserved-ranges = <20 4>, /* SPI (Fingerprint scanner) */
+						   <40 4>; /* I2C (Unused) */
 };
 
 &usb_1 {
-- 
2.51.0

Re: [PATCH] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins

Posted by Dmitry Baryshkov 4 months, 2 weeks ago

On Sun, Sep 21, 2025 at 01:56:23PM +0000, Eric Gonçalves wrote:
> The S20 series has additional reserved pins for the fingerprint sensor,
> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
> 
> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> index 96662bf9e527..1680be67e733 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> @@ -159,7 +159,8 @@ &pon_resin {
>  };
>  
>  &tlmm {
> -	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
> +	gpio-reserved-ranges = <20 4>, /* SPI (Fingerprint scanner) */
> +						   <40 4>; /* I2C (Unused) */

Typically Tab size is 8 spaces, not 4.


Also:

Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")


>  };
>  
>  &usb_1 {
> -- 
> 2.51.0
> 

-- 
With best wishes
Dmitry

Re: [PATCH] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins

Posted by Eric Gonçalves 4 months, 1 week ago


On September 22, 2025 6:51:30 AM GMT-03:00, Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote:
>On Sun, Sep 21, 2025 at 01:56:23PM +0000, Eric Gonçalves wrote:
>> The S20 series has additional reserved pins for the fingerprint sensor,
>> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
>> 
>> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
>> ---
>>  arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> index 96662bf9e527..1680be67e733 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> @@ -159,7 +159,8 @@ &pon_resin {
>>  };
>>  
>>  &tlmm {
>> -	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
>> +	gpio-reserved-ranges = <20 4>, /* SPI (Fingerprint scanner) */
>> +						   <40 4>; /* I2C (Unused) */
>
>Typically Tab size is 8 spaces, not 4.
I'll change that, thanks
>
>
>Also:
>
>Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
>
>
>>  };
>>  
>>  &usb_1 {
>> -- 
>> 2.51.0
>> 
>