.../boot/dts/rockchip/rk3399-pinephone-pro.dts | 42 ++++++++++++++++++++-- 1 file changed, 40 insertions(+), 2 deletions(-)
Throughout the years, many have contributed to the Pinephone Pro (ppp)
development. Unfortunately, these patches are scattered around various
repositories in different states.
I will be attempting to upstream these patches. I will start off with the
following small series:
- Add light/proximity sensor support
- https://codeberg.org/megi/linux/commit/f171bc7013bc7ad3de9af817bfbcbfa548ebe01c
- Add accelerometer sensor support
- https://codeberg.org/megi/linux/commit/b0bb7633e073a6760fa213b8c4a78ea2e73c7bf1
- Add magnetometer sensor support
- https://codeberg.org/megi/linux/commit/2f7e67f451f16eaf15b81aa1dbdf126d54927d35
- Add mount-matrix for magnetometer
- https://codeberg.org/megi/linux/commit/d7cd2eab931e32fa94408a96d73b4e6c0616107a
- Fix voltage threshold for volume down key
- https://codeberg.org/megi/linux/commit/7c496a5cc27ed4e38b740f36c2d8b2c62f80ae54
Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
---
Changes in v3:
- change magnetometer mount matrix
- update volume button threshold
- Link to v2: https://lore.kernel.org/r/20250921-ppp_light_accel_mag_vol-down-v2-0-e6bcc6ca74ae@gmail.com
Changes in v2:
- remove usb-typec node in dts from light/proximity sensor patch
- Link to v1: https://lore.kernel.org/r/20250920-ppp_light_accel_mag_vol-down-v1-0-c8bbcd3e2e94@gmail.com
---
Leonardo G. Trombetta (1):
arm64: dts: rk3399-pinephone-pro: Add mount-matrix for magnetometer
Ondrej Jirman (4):
arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor support
arm64: dts: rk3399-pinephone-pro: Add accelerometer sensor support
arm64: dts: rk3399-pinephone-pro: Add magnetometer sensor support
arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for volume keys
.../boot/dts/rockchip/rk3399-pinephone-pro.dts | 42 ++++++++++++++++++++--
1 file changed, 40 insertions(+), 2 deletions(-)
---
base-commit: f83ec76bf285bea5727f478a68b894f5543ca76e
change-id: 20250920-ppp_light_accel_mag_vol-down-817c84fdae8d
Best regards,
--
Rudraksha Gupta <guptarud@gmail.com>
Hello Rudraksha, On 2025-09-21 23:05, Rudraksha Gupta via B4 Relay wrote: > Throughout the years, many have contributed to the Pinephone Pro (ppp) > development. Unfortunately, these patches are scattered around various > repositories in different states. Thanks for submitting these patches. However, please expand the patch descriptions, because their current forms are too terse and, as such, simply not acceptable. This applies to all patches in this series. I'm also under impression that you're submitting these patches upstream blindly and without researching the rules that apply well enough, which may not be the best possible approach. Finally, please refrain yourself from sending multiple versions of the same patch series in the same day. Doing so makes reviewing the patches unnecessarily hard. > I will be attempting to upstream these patches. I will start off with > the > following small series: > - Add light/proximity sensor support > - > https://codeberg.org/megi/linux/commit/f171bc7013bc7ad3de9af817bfbcbfa548ebe01c > - Add accelerometer sensor support > - > https://codeberg.org/megi/linux/commit/b0bb7633e073a6760fa213b8c4a78ea2e73c7bf1 > - Add magnetometer sensor support > - > https://codeberg.org/megi/linux/commit/2f7e67f451f16eaf15b81aa1dbdf126d54927d35 > - Add mount-matrix for magnetometer > - > https://codeberg.org/megi/linux/commit/d7cd2eab931e32fa94408a96d73b4e6c0616107a > - Fix voltage threshold for volume down key > - > https://codeberg.org/megi/linux/commit/7c496a5cc27ed4e38b740f36c2d8b2c62f80ae54 > > Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> > --- > Changes in v3: > - change magnetometer mount matrix > - update volume button threshold > - Link to v2: > https://lore.kernel.org/r/20250921-ppp_light_accel_mag_vol-down-v2-0-e6bcc6ca74ae@gmail.com > > Changes in v2: > - remove usb-typec node in dts from light/proximity sensor patch > - Link to v1: > https://lore.kernel.org/r/20250920-ppp_light_accel_mag_vol-down-v1-0-c8bbcd3e2e94@gmail.com > > --- > Leonardo G. Trombetta (1): > arm64: dts: rk3399-pinephone-pro: Add mount-matrix for > magnetometer > > Ondrej Jirman (4): > arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor > support > arm64: dts: rk3399-pinephone-pro: Add accelerometer sensor > support > arm64: dts: rk3399-pinephone-pro: Add magnetometer sensor support > arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for > volume keys > > .../boot/dts/rockchip/rk3399-pinephone-pro.dts | 42 > ++++++++++++++++++++-- > 1 file changed, 40 insertions(+), 2 deletions(-)
Hi, > Thanks for submitting these patches. However, please expand the patch > descriptions, because their current forms are too terse and, as such, > simply not acceptable. This applies to all patches in this series. Gotcha, will do! I've added the testing that I did. From https://docs.kernel.org/process/submitting-patches.html > The text should be written in such detail so that when read weeks, months or even years later, it can give the reader the needed details to grasp the reasoning for why the patch was created. It felt like saying more than "adding x sensor" seemed like adding fluff to me, so that is why I kept it short. Let me know if there is something else I should add beside the tests I have done. > I'm also under impression that you're submitting these patches upstream > blindly and without researching the rules that apply well enough, which > may not be the best possible approach. Sorry! I've read https://docs.kernel.org/process/submitting-patches.html a bunch of times during the years I have contributed to the Linux kernel and inevitably forget something. Please feel free to tell me what I've done wrong! I've corrected my mistakes in v4 (and undoubtedly probably introduced more, but feel free to tell me that ;) ) > > Finally, please refrain yourself from sending multiple versions of the > same patch series in the same day. Doing so makes reviewing the patches > unnecessarily hard. Sorry about that once again! I'm mostly a hobbyist that loves working on Linux over the weekend. I wanted to get correct my mistakes so that I can get reviews over the week. I wish lkml used a forge, so I didn't have to spam you, but I digress. I will keep this in mind moving forward. Rudraksha
Hello Rudraksha, On 2025-09-29 09:44, Rudraksha Gupta wrote: >> Thanks for submitting these patches. However, please expand the patch >> descriptions, because their current forms are too terse and, as such, >> simply not acceptable. This applies to all patches in this series. > > Gotcha, will do! I've added the testing that I did. From > https://docs.kernel.org/process/submitting-patches.html > >> The text should be written in such detail so that when read weeks, >> months or even years later, it can give the reader the needed details >> to grasp the reasoning for why the patch was created. > > It felt like saying more than "adding x sensor" seemed like adding > fluff to me, so that is why I kept it short. Let me know if there is > something else I should add beside the tests I have done. Thanks for improving the patch descriptions in the v4 of this series. I just went quickly through the v4 and it looks much better. It could be said that the new patch descriptions are now a bit too verbose, in the sense that the test procedures and their results could be summed up a bit better in prose, instead of providing the "raw" inputs and outputs. However, it's still better to have those, than not to have anything. Writing good prose is a skill that usually requires learning and practice. >> I'm also under impression that you're submitting these patches >> upstream >> blindly and without researching the rules that apply well enough, >> which >> may not be the best possible approach. > > Sorry! I've read > https://docs.kernel.org/process/submitting-patches.html a bunch of > times during the years I have contributed to the Linux kernel and > inevitably forget something. Please feel free to tell me what I've > done wrong! I've corrected my mistakes in v4 (and undoubtedly probably > introduced more, but feel free to tell me that ;) ) You haven't done anything technically wrong, but the way you submitted the v2 and v3 made them feel a bit like you picked those patches from some random place and submitted them to the mailing list without really understanding the subject matter. In other words, it's the contributor's job to convince everyone else that the submitted patches are fine to become accepted, and the v2 and v3 simply lacked that. >> Finally, please refrain yourself from sending multiple versions of the >> same patch series in the same day. Doing so makes reviewing the >> patches >> unnecessarily hard. > > Sorry about that once again! I'm mostly a hobbyist that loves working > on Linux over the weekend. I wanted to get correct my mistakes so that > I can get reviews over the week. I wish lkml used a forge, so I didn't > have to spam you, but I digress. I will keep this in mind moving > forward. I wonder how would some forge prevent "spamming"? It isn't about the possible "spamming", but about the act of submitting different versions, which would be present regardless of the way they'd be submitted, and the reviewers would need to be aware (i.e. "spammed") of them anyway.
On Sun, 21 Sep 2025 14:05:53 -0700, Rudraksha Gupta wrote: > Throughout the years, many have contributed to the Pinephone Pro (ppp) > development. Unfortunately, these patches are scattered around various > repositories in different states. > > I will be attempting to upstream these patches. I will start off with the > following small series: > - Add light/proximity sensor support > - https://codeberg.org/megi/linux/commit/f171bc7013bc7ad3de9af817bfbcbfa548ebe01c > - Add accelerometer sensor support > - https://codeberg.org/megi/linux/commit/b0bb7633e073a6760fa213b8c4a78ea2e73c7bf1 > - Add magnetometer sensor support > - https://codeberg.org/megi/linux/commit/2f7e67f451f16eaf15b81aa1dbdf126d54927d35 > - Add mount-matrix for magnetometer > - https://codeberg.org/megi/linux/commit/d7cd2eab931e32fa94408a96d73b4e6c0616107a > - Fix voltage threshold for volume down key > - https://codeberg.org/megi/linux/commit/7c496a5cc27ed4e38b740f36c2d8b2c62f80ae54 > > Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> > --- > Changes in v3: > - change magnetometer mount matrix > - update volume button threshold > - Link to v2: https://lore.kernel.org/r/20250921-ppp_light_accel_mag_vol-down-v2-0-e6bcc6ca74ae@gmail.com > > Changes in v2: > - remove usb-typec node in dts from light/proximity sensor patch > - Link to v1: https://lore.kernel.org/r/20250920-ppp_light_accel_mag_vol-down-v1-0-c8bbcd3e2e94@gmail.com > > --- > Leonardo G. Trombetta (1): > arm64: dts: rk3399-pinephone-pro: Add mount-matrix for magnetometer > > Ondrej Jirman (4): > arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor support > arm64: dts: rk3399-pinephone-pro: Add accelerometer sensor support > arm64: dts: rk3399-pinephone-pro: Add magnetometer sensor support > arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for volume keys > > .../boot/dts/rockchip/rk3399-pinephone-pro.dts | 42 ++++++++++++++++++++-- > 1 file changed, 40 insertions(+), 2 deletions(-) > --- > base-commit: f83ec76bf285bea5727f478a68b894f5543ca76e > change-id: 20250920-ppp_light_accel_mag_vol-down-817c84fdae8d > > Best regards, > -- > Rudraksha Gupta <guptarud@gmail.com> > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade This patch series was applied (using b4) to base: Base: using specified base-commit f83ec76bf285bea5727f478a68b894f5543ca76e If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically) New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250921-ppp_light_accel_mag_vol-down-v3-0-7af6651f77e4@gmail.com: arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dtb: light-sensor@48 (sensortek,stk3311): 'leda-supply', 'vdd-supply' do not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/iio/light/stk33xx.yaml#
Hi, > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > This patch series was applied (using b4) to base: > Base: using specified base-commit f83ec76bf285bea5727f478a68b894f5543ca76e > > If this is not the correct base, please add 'base-commit' tag > (or use b4 which does this automatically) > > New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250921-ppp_light_accel_mag_vol-down-v3-0-7af6651f77e4@gmail.com: > > arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dtb: light-sensor@48 (sensortek,stk3311): 'leda-supply', 'vdd-supply' do not match any of the regexes: '^pinctrl-[0-9]+$' > from schema $id: http://devicetree.org/schemas/iio/light/stk33xx.yaml# Thanks, addressed in v4! Rudraksha
© 2016 - 2025 Red Hat, Inc.