[PATCH iproute2-next 2/3] iplink_can: fix SPDX-License-Identifier tag format

Vincent Mailhol posted 3 patches 1 week, 3 days ago
[PATCH iproute2-next 2/3] iplink_can: fix SPDX-License-Identifier tag format
Posted by Vincent Mailhol 1 week, 3 days ago
In .c files, the SPDX tag uses the C++ comment style.

Fix below checkpatch.pl warning:

  WARNING: Improper SPDX comment style for 'ip/iplink_can.c', please use '//' instead
  #1: FILE: ip/iplink_can.c:1:
  +/* SPDX-License-Identifier: GPL-2.0-or-later */

  WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
  #1: FILE: ip/iplink_can.c:1:
  +/* SPDX-License-Identifier: GPL-2.0-or-later */

Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
---
 ip/iplink_can.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ip/iplink_can.c b/ip/iplink_can.c
index 1afdf08825f3d9cbbb0454592d2ed7dc1388a6de..56c258b023ef57e37574f44981b76086a0a140db 100644
--- a/ip/iplink_can.c
+++ b/ip/iplink_can.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  * iplink_can.c	CAN device support
  *

-- 
2.49.1
Re: [PATCH iproute2-next 2/3] iplink_can: fix SPDX-License-Identifier tag format
Posted by Stephen Hemminger 1 week, 2 days ago
On Sun, 21 Sep 2025 16:32:31 +0900
Vincent Mailhol <mailhol@kernel.org> wrote:

> In .c files, the SPDX tag uses the C++ comment style.
> 
> Fix below checkpatch.pl warning:
> 
>   WARNING: Improper SPDX comment style for 'ip/iplink_can.c', please use '//' instead
>   #1: FILE: ip/iplink_can.c:1:
>   +/* SPDX-License-Identifier: GPL-2.0-or-later */
> 
>   WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
>   #1: FILE: ip/iplink_can.c:1:
>   +/* SPDX-License-Identifier: GPL-2.0-or-later */
> 
> Signed-off-by: Vincent Mailhol <mailhol@kernel.org>

NAK
Iproute2 excepts both formats and both are used in several
places.