LIBBPF_DYNAMIC=1 fixes

[PATCH 0/2] LIBBPF_DYNAMIC=1 fixes

Posted by Arnaldo Carvalho de Melo 1 week, 5 days ago

Hi,

	Please take a look, noticed after processing a patch from Ian
for another such issue, on a hurry now, haven't checked when that
emit_string was introduced.

- Arnaldo

Arnaldo Carvalho de Melo (2):
  perf bpf: Move the LIBBPF_CURRENT_VERSION_GEQ macro to bpf-utils.h
  perf bpf: Check libbpf version to use
    btf_dump_type_data_opts.emit_strings

 tools/perf/util/bpf-event.c  | 2 ++
 tools/perf/util/bpf-filter.c | 5 +----
 tools/perf/util/bpf-utils.h  | 5 +++++
 3 files changed, 8 insertions(+), 4 deletions(-)

-- 
2.51.0

Re: [PATCH 0/2] LIBBPF_DYNAMIC=1 fixes

Posted by Namhyung Kim 1 week, 5 days ago

On Fri, Sep 19, 2025 at 06:06:52PM -0300, Arnaldo Carvalho de Melo wrote:
> Hi,
> 
> 	Please take a look, noticed after processing a patch from Ian
> for another such issue, on a hurry now, haven't checked when that
> emit_string was introduced.
> 
> - Arnaldo
> 
> Arnaldo Carvalho de Melo (2):
>   perf bpf: Move the LIBBPF_CURRENT_VERSION_GEQ macro to bpf-utils.h
>   perf bpf: Check libbpf version to use
>     btf_dump_type_data_opts.emit_strings

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

> 
>  tools/perf/util/bpf-event.c  | 2 ++
>  tools/perf/util/bpf-filter.c | 5 +----
>  tools/perf/util/bpf-utils.h  | 5 +++++
>  3 files changed, 8 insertions(+), 4 deletions(-)
> 
> -- 
> 2.51.0
>

Re: [PATCH 0/2] LIBBPF_DYNAMIC=1 fixes

Posted by Ian Rogers 1 week, 5 days ago

On Fri, Sep 19, 2025 at 2:58 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> On Fri, Sep 19, 2025 at 06:06:52PM -0300, Arnaldo Carvalho de Melo wrote:
> > Hi,
> >
> >       Please take a look, noticed after processing a patch from Ian
> > for another such issue, on a hurry now, haven't checked when that
> > emit_string was introduced.

emit_strings was added in Linux v6.17 and libbpf was tagged as version
1.7 prior to that.

Thanks,
Ian

> >
> > - Arnaldo
> >
> > Arnaldo Carvalho de Melo (2):
> >   perf bpf: Move the LIBBPF_CURRENT_VERSION_GEQ macro to bpf-utils.h
> >   perf bpf: Check libbpf version to use
> >     btf_dump_type_data_opts.emit_strings
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
>
> Thanks,
> Namhyung
>
> >
> >  tools/perf/util/bpf-event.c  | 2 ++
> >  tools/perf/util/bpf-filter.c | 5 +----
> >  tools/perf/util/bpf-utils.h  | 5 +++++
> >  3 files changed, 8 insertions(+), 4 deletions(-)
> >
> > --
> > 2.51.0
> >

Re: [PATCH 0/2] LIBBPF_DYNAMIC=1 fixes

Posted by Ian Rogers 1 day, 8 hours ago

On Fri, Sep 19, 2025 at 3:10 PM Ian Rogers <irogers@google.com> wrote:
>
> On Fri, Sep 19, 2025 at 2:58 PM Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > On Fri, Sep 19, 2025 at 06:06:52PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Hi,
> > >
> > >       Please take a look, noticed after processing a patch from Ian
> > > for another such issue, on a hurry now, haven't checked when that
> > > emit_string was introduced.
>
> emit_strings was added in Linux v6.17 and libbpf was tagged as version
> 1.7 prior to that.
>
> Thanks,
> Ian

Ping.

When this lands I can rebase:
https://lore.kernel.org/lkml/20250830053549.1966520-1-irogers@google.com/
on it.

Thanks,
Ian

> > >
> > > - Arnaldo
> > >
> > > Arnaldo Carvalho de Melo (2):
> > >   perf bpf: Move the LIBBPF_CURRENT_VERSION_GEQ macro to bpf-utils.h
> > >   perf bpf: Check libbpf version to use
> > >     btf_dump_type_data_opts.emit_strings
> >
> > Acked-by: Namhyung Kim <namhyung@kernel.org>
> >
> > Thanks,
> > Namhyung
> >
> > >
> > >  tools/perf/util/bpf-event.c  | 2 ++
> > >  tools/perf/util/bpf-filter.c | 5 +----
> > >  tools/perf/util/bpf-utils.h  | 5 +++++
> > >  3 files changed, 8 insertions(+), 4 deletions(-)
> > >
> > > --
> > > 2.51.0
> > >

Re: [PATCH 0/2] LIBBPF_DYNAMIC=1 fixes

Posted by Arnaldo Carvalho de Melo 15 hours ago

On Tue, Sep 30, 2025 at 01:10:59PM -0700, Ian Rogers wrote:
> On Fri, Sep 19, 2025 at 3:10 PM Ian Rogers <irogers@google.com> wrote:
> >
> > On Fri, Sep 19, 2025 at 2:58 PM Namhyung Kim <namhyung@kernel.org> wrote:
> > >
> > > On Fri, Sep 19, 2025 at 06:06:52PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > Hi,
> > > >
> > > >       Please take a look, noticed after processing a patch from Ian
> > > > for another such issue, on a hurry now, haven't checked when that
> > > > emit_string was introduced.
> >
> > emit_strings was added in Linux v6.17 and libbpf was tagged as version
> > 1.7 prior to that.
> >
> > Thanks,
> > Ian
> 
> Ping.
> 
> When this lands I can rebase:
> https://lore.kernel.org/lkml/20250830053549.1966520-1-irogers@google.com/
> on it.

I'm testing this now.

- Arnaldo
 
> Thanks,
> Ian
> 
> > > >
> > > > - Arnaldo
> > > >
> > > > Arnaldo Carvalho de Melo (2):
> > > >   perf bpf: Move the LIBBPF_CURRENT_VERSION_GEQ macro to bpf-utils.h
> > > >   perf bpf: Check libbpf version to use
> > > >     btf_dump_type_data_opts.emit_strings
> > >
> > > Acked-by: Namhyung Kim <namhyung@kernel.org>
> > >
> > > Thanks,
> > > Namhyung
> > >
> > > >
> > > >  tools/perf/util/bpf-event.c  | 2 ++
> > > >  tools/perf/util/bpf-filter.c | 5 +----
> > > >  tools/perf/util/bpf-utils.h  | 5 +++++
> > > >  3 files changed, 8 insertions(+), 4 deletions(-)
> > > >
> > > > --
> > > > 2.51.0
> > > >