drivers: mhi: make mhi_ep_bus_type const

[PATCH] drivers: mhi: make mhi_ep_bus_type const

Posted by Adrian Barnaś 4 months, 3 weeks ago

Because driver core can properly handle constant struct bus_type,
move the mhi_ep_bus_type to be a constant structure as well, placing it
into read-only memory which can not be modified at runtime.

Signed-off-by: Adrian Barnaś <abarnas@google.com>
---
 drivers/bus/mhi/ep/internal.h | 2 +-
 drivers/bus/mhi/ep/main.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/mhi/ep/internal.h b/drivers/bus/mhi/ep/internal.h
index 577965f95fda..512da7482acc 100644
--- a/drivers/bus/mhi/ep/internal.h
+++ b/drivers/bus/mhi/ep/internal.h
@@ -11,7 +11,7 @@
 
 #include "../common.h"
 
-extern struct bus_type mhi_ep_bus_type;
+extern const struct bus_type mhi_ep_bus_type;
 
 #define MHI_REG_OFFSET				0x100
 #define BHI_REG_OFFSET				0x200
diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
index cdea24e92919..86e003bc44e0 100644
--- a/drivers/bus/mhi/ep/main.c
+++ b/drivers/bus/mhi/ep/main.c
@@ -1703,7 +1703,7 @@ static int mhi_ep_match(struct device *dev, const struct device_driver *drv)
 	return 0;
 };
 
-struct bus_type mhi_ep_bus_type = {
+const struct bus_type mhi_ep_bus_type = {
 	.name = "mhi_ep",
 	.dev_name = "mhi_ep",
 	.match = mhi_ep_match,
-- 
2.51.0.534.gc79095c0ca-goog

Re: [PATCH] drivers: mhi: make mhi_ep_bus_type const

Posted by Manivannan Sadhasivam 3 months, 3 weeks ago

On Fri, Sep 19, 2025 at 07:44:08AM +0000, Adrian Barnaś wrote:
> Because driver core can properly handle constant struct bus_type,
> move the mhi_ep_bus_type to be a constant structure as well, placing it
> into read-only memory which can not be modified at runtime.
> 
> Signed-off-by: Adrian Barnaś <abarnas@google.com>

Applied to mhi-next!

- Mani

> ---
>  drivers/bus/mhi/ep/internal.h | 2 +-
>  drivers/bus/mhi/ep/main.c     | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bus/mhi/ep/internal.h b/drivers/bus/mhi/ep/internal.h
> index 577965f95fda..512da7482acc 100644
> --- a/drivers/bus/mhi/ep/internal.h
> +++ b/drivers/bus/mhi/ep/internal.h
> @@ -11,7 +11,7 @@
>  
>  #include "../common.h"
>  
> -extern struct bus_type mhi_ep_bus_type;
> +extern const struct bus_type mhi_ep_bus_type;
>  
>  #define MHI_REG_OFFSET				0x100
>  #define BHI_REG_OFFSET				0x200
> diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
> index cdea24e92919..86e003bc44e0 100644
> --- a/drivers/bus/mhi/ep/main.c
> +++ b/drivers/bus/mhi/ep/main.c
> @@ -1703,7 +1703,7 @@ static int mhi_ep_match(struct device *dev, const struct device_driver *drv)
>  	return 0;
>  };
>  
> -struct bus_type mhi_ep_bus_type = {
> +const struct bus_type mhi_ep_bus_type = {
>  	.name = "mhi_ep",
>  	.dev_name = "mhi_ep",
>  	.match = mhi_ep_match,
> -- 
> 2.51.0.534.gc79095c0ca-goog
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH] drivers: mhi: make mhi_ep_bus_type const

Posted by Greg Kroah-Hartman 4 months, 3 weeks ago

On Fri, Sep 19, 2025 at 07:44:08AM +0000, Adrian Barnaś wrote:
> Because driver core can properly handle constant struct bus_type,
> move the mhi_ep_bus_type to be a constant structure as well, placing it
> into read-only memory which can not be modified at runtime.
> 
> Signed-off-by: Adrian Barnaś <abarnas@google.com>
> ---
>  drivers/bus/mhi/ep/internal.h | 2 +-
>  drivers/bus/mhi/ep/main.c     | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>