staging: gpib: enclose macro values in parentheses

[PATCH] staging: gpib: enclose macro values in parentheses

Posted by Soumya Ranjan Patnaik 1 week, 5 days ago

Macros with complex values should be enclosed in parentheses to avoid
unexpected behavior due to operator precedence or macro expansion issues.
This change wraps the LINVAL macro values in parentheses to comply with
kernel coding style and improve code safety.

Signed-off-by: Soumya Ranjan Patnaik <soumyaranjan1812@gmail.com>
---
 drivers/staging/gpib/gpio/gpib_bitbang.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpib/gpio/gpib_bitbang.c
index 17884810f..ad82be69d 100644
--- a/drivers/staging/gpib/gpio/gpib_bitbang.c
+++ b/drivers/staging/gpib/gpio/gpib_bitbang.c
@@ -47,10 +47,10 @@
 			dev_dbg(board->gpib_dev, frm, ## __VA_ARGS__); } \
 	while (0)

-#define LINVAL gpiod_get_value(DAV),		\
+#define LINVAL (gpiod_get_value(DAV),		\
 		gpiod_get_value(NRFD),		\
 		gpiod_get_value(NDAC),		\
-		gpiod_get_value(SRQ)
+		gpiod_get_value(SRQ))
 #define LINFMT "DAV: %d	 NRFD:%d  NDAC: %d SRQ: %d"

 #include "gpibP.h"
--
2.47.2

Re: [PATCH] staging: gpib: enclose macro values in parentheses

Posted by Dan Carpenter 1 week, 5 days ago

On Fri, Sep 19, 2025 at 12:33:48PM +0530, Soumya Ranjan Patnaik wrote:
> Macros with complex values should be enclosed in parentheses to avoid
> unexpected behavior due to operator precedence or macro expansion issues.
> This change wraps the LINVAL macro values in parentheses to comply with
> kernel coding style and improve code safety.
> 
> Signed-off-by: Soumya Ranjan Patnaik <soumyaranjan1812@gmail.com>

That's going to break the build.

https://lore.kernel.org/all/?q=LINVAL

regards,
dan carpenter