[PATCH] drivers: eisa: make eisa_bus_type const

Adrian Barnaś posted 1 patch 1 week, 5 days ago
drivers/eisa/eisa-bus.c | 2 +-
include/linux/eisa.h    | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[PATCH] drivers: eisa: make eisa_bus_type const
Posted by Adrian Barnaś 1 week, 5 days ago
Because driver core can properly handle constant struct bus_type,
move the eisa_bus_type to be a constant structure as well, placing it into
read-only memory which can not be modified at runtime.

Signed-off-by: Adrian Barnaś <abarnas@google.com>
---
 drivers/eisa/eisa-bus.c | 2 +-
 include/linux/eisa.h    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/eisa/eisa-bus.c b/drivers/eisa/eisa-bus.c
index edceea083b98..bd76d599109c 100644
--- a/drivers/eisa/eisa-bus.c
+++ b/drivers/eisa/eisa-bus.c
@@ -135,7 +135,7 @@ static int eisa_bus_uevent(const struct device *dev, struct kobj_uevent_env *env
 	return 0;
 }
 
-struct bus_type eisa_bus_type = {
+const struct bus_type eisa_bus_type = {
 	.name  = "eisa",
 	.match = eisa_bus_match,
 	.uevent = eisa_bus_uevent,
diff --git a/include/linux/eisa.h b/include/linux/eisa.h
index 21a2ecc1e538..cf55630b595b 100644
--- a/include/linux/eisa.h
+++ b/include/linux/eisa.h
@@ -68,7 +68,7 @@ struct eisa_driver {
 /* These external functions are only available when EISA support is enabled. */
 #ifdef CONFIG_EISA
 
-extern struct bus_type eisa_bus_type;
+extern const struct bus_type eisa_bus_type;
 int eisa_driver_register (struct eisa_driver *edrv);
 void eisa_driver_unregister (struct eisa_driver *edrv);
 
-- 
2.51.0.534.gc79095c0ca-goog
Re: [PATCH] drivers: eisa: make eisa_bus_type const
Posted by Greg Kroah-Hartman 1 week, 5 days ago
On Fri, Sep 19, 2025 at 06:53:27AM +0000, Adrian Barnaś wrote:
> Because driver core can properly handle constant struct bus_type,
> move the eisa_bus_type to be a constant structure as well, placing it into
> read-only memory which can not be modified at runtime.
> 
> Signed-off-by: Adrian Barnaś <abarnas@google.com>
> ---
>  drivers/eisa/eisa-bus.c | 2 +-
>  include/linux/eisa.h    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>