On Fri, Sep 19, 2025 at 03:17:11PM +0300, Abel Vesa wrote:
> The platform specific configuration is already passed on to the generic
> msm probe. So it's useless to exist in the match table next to the
> compatible. So drop it from match table.
>
> Fixes: 87ebcd8baebf ("pinctrl: qcom: Add glymur pinctrl driver")
No need for this tag.
Other than that:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/pinctrl/qcom/pinctrl-glymur.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-glymur.c b/drivers/pinctrl/qcom/pinctrl-glymur.c
> index 9913f98e953110d32e804c8d210220857583ba46..9781e7fcb3a11c85dbd5497170188e2da051215b 100644
> --- a/drivers/pinctrl/qcom/pinctrl-glymur.c
> +++ b/drivers/pinctrl/qcom/pinctrl-glymur.c
> @@ -1743,7 +1743,7 @@ static const struct msm_pinctrl_soc_data glymur_tlmm = {
> };
>
> static const struct of_device_id glymur_tlmm_of_match[] = {
> - { .compatible = "qcom,glymur-tlmm", .data = &glymur_tlmm },
> + { .compatible = "qcom,glymur-tlmm", },
> { }
> };
>
>
> --
> 2.48.1
>
--
With best wishes
Dmitry