[PATCH] powerpc: cell: make spu_subsys const

Adrian Barnaś posted 1 patch 1 week, 6 days ago
arch/powerpc/platforms/cell/spu_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] powerpc: cell: make spu_subsys const
Posted by Adrian Barnaś 1 week, 6 days ago
Because driver core can properly handle constant struct bus_type,
move the spu_subsys to be a constant structure as well, placing it into
read-only memory which can not be modified at runtime.

Signed-off-by: Adrian Barnaś <abarnas@google.com>
---
 arch/powerpc/platforms/cell/spu_base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c
index 2c07387201d0..733b512992c0 100644
--- a/arch/powerpc/platforms/cell/spu_base.c
+++ b/arch/powerpc/platforms/cell/spu_base.c
@@ -464,7 +464,7 @@ void spu_init_channels(struct spu *spu)
 }
 EXPORT_SYMBOL_GPL(spu_init_channels);
 
-static struct bus_type spu_subsys = {
+static const struct bus_type spu_subsys = {
 	.name = "spu",
 	.dev_name = "spu",
 };
-- 
2.51.0.470.ga7dc726c21-goog
Re: [PATCH] powerpc: cell: make spu_subsys const
Posted by Greg Kroah-Hartman 1 week, 6 days ago
On Thu, Sep 18, 2025 at 02:16:33PM +0000, Adrian Barnaś wrote:
> Because driver core can properly handle constant struct bus_type,
> move the spu_subsys to be a constant structure as well, placing it into
> read-only memory which can not be modified at runtime.
> 
> Signed-off-by: Adrian Barnaś <abarnas@google.com>
> ---
>  arch/powerpc/platforms/cell/spu_base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c
> index 2c07387201d0..733b512992c0 100644
> --- a/arch/powerpc/platforms/cell/spu_base.c
> +++ b/arch/powerpc/platforms/cell/spu_base.c
> @@ -464,7 +464,7 @@ void spu_init_channels(struct spu *spu)
>  }
>  EXPORT_SYMBOL_GPL(spu_init_channels);
>  
> -static struct bus_type spu_subsys = {
> +static const struct bus_type spu_subsys = {
>  	.name = "spu",
>  	.dev_name = "spu",
>  };
> -- 
> 2.51.0.470.ga7dc726c21-goog
> 

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>