hwtracing: intel_th: make intel_th_bus const

[PATCH] hwtracing: intel_th: make intel_th_bus const

Posted by Adrian Barnaś 4 months, 3 weeks ago

Because driver core can properly handle constant struct bus_type,
move the intel_th_bus to be a constant structure as well, placing it into
read-only memory which can not be modified at runtime.

Signed-off-by: Adrian Barnaś <abarnas@google.com>
---
 drivers/hwtracing/intel_th/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/intel_th/core.c b/drivers/hwtracing/intel_th/core.c
index 47d9e6c3bac0..ba7c8b184cbc 100644
--- a/drivers/hwtracing/intel_th/core.c
+++ b/drivers/hwtracing/intel_th/core.c
@@ -166,7 +166,7 @@ static void intel_th_remove(struct device *dev)
 	pm_runtime_enable(dev);
 }
 
-static struct bus_type intel_th_bus = {
+static const struct bus_type intel_th_bus = {
 	.name		= "intel_th",
 	.match		= intel_th_match,
 	.probe		= intel_th_probe,
-- 
2.51.0.470.ga7dc726c21-goog

Re: [PATCH] hwtracing: intel_th: make intel_th_bus const

Posted by Greg Kroah-Hartman 4 months, 3 weeks ago

On Thu, Sep 18, 2025 at 01:39:37PM +0000, Adrian Barnaś wrote:
> Because driver core can properly handle constant struct bus_type,
> move the intel_th_bus to be a constant structure as well, placing it into
> read-only memory which can not be modified at runtime.
> 
> Signed-off-by: Adrian Barnaś <abarnas@google.com>
> ---
>  drivers/hwtracing/intel_th/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/intel_th/core.c b/drivers/hwtracing/intel_th/core.c
> index 47d9e6c3bac0..ba7c8b184cbc 100644
> --- a/drivers/hwtracing/intel_th/core.c
> +++ b/drivers/hwtracing/intel_th/core.c
> @@ -166,7 +166,7 @@ static void intel_th_remove(struct device *dev)
>  	pm_runtime_enable(dev);
>  }
>  
> -static struct bus_type intel_th_bus = {
> +static const struct bus_type intel_th_bus = {
>  	.name		= "intel_th",
>  	.match		= intel_th_match,
>  	.probe		= intel_th_probe,
> -- 
> 2.51.0.470.ga7dc726c21-goog
> 

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>