sound/soc/pxa/mmp-sspa.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
Return -EOPNOTSUPP from mmp_sspa_set_dai_sysclk() instead of -EINVAL for
unsupported clock ids, and remove the obsolete comment.
Replace other -ENOTSUPP returns with -EOPNOTSUPP to comply with SUSv4
error code guidelines and silence multiple checkpatch warnings:
ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
sound/soc/pxa/mmp-sspa.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/sound/soc/pxa/mmp-sspa.c b/sound/soc/pxa/mmp-sspa.c
index 73f36c9dd35c..38815ca8f152 100644
--- a/sound/soc/pxa/mmp-sspa.c
+++ b/sound/soc/pxa/mmp-sspa.c
@@ -111,7 +111,7 @@ static int mmp_sspa_set_dai_sysclk(struct snd_soc_dai *cpu_dai,
int ret = 0;
if (dev->of_node)
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
switch (clk_id) {
case MMP_SSPA_CLK_AUDIO:
@@ -121,8 +121,7 @@ static int mmp_sspa_set_dai_sysclk(struct snd_soc_dai *cpu_dai,
break;
case MMP_SSPA_CLK_PLL:
case MMP_SSPA_CLK_VCXO:
- /* not support yet */
- return -EINVAL;
+ return -EOPNOTSUPP;
default:
return -EINVAL;
}
@@ -139,7 +138,7 @@ static int mmp_sspa_set_dai_pll(struct snd_soc_dai *cpu_dai, int pll_id,
int ret = 0;
if (dev->of_node)
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
switch (pll_id) {
case MMP_SYSCLK:
--
2.51.0
On Thu, Sep 18, 2025 at 01:21:02PM +0200, Thorsten Blum wrote: > Return -EOPNOTSUPP from mmp_sspa_set_dai_sysclk() instead of -EINVAL for > unsupported clock ids, and remove the obsolete comment. Why?
On 18. Sep 2025, at 13:33, Mark Brown wrote: > On Thu, Sep 18, 2025 at 01:21:02PM +0200, Thorsten Blum wrote: > >> Return -EOPNOTSUPP from mmp_sspa_set_dai_sysclk() instead of -EINVAL for >> unsupported clock ids, and remove the obsolete comment. > > Why? The comment says "not supported yet", so returning -EOPNOTSUPP (or -ENOTSUPP) reflects this more accurately than -EINVAL, unless I misunderstood something. Feel free to ignore this patch if it's inconsistent with how other drivers handle this (I didn't check tbh). Thanks, Thorsten
© 2016 - 2025 Red Hat, Inc.