[PATCH 0/2] arm64: dts: rockchip: fix dma and pinctrl defs v2

Ed Wildgoose posted 2 patches 1 week, 6 days ago
.../dts/rockchip/rk3566-radxa-zero-3.dtsi     | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)
[PATCH 0/2] arm64: dts: rockchip: fix dma and pinctrl defs v2
Posted by Ed Wildgoose 1 week, 6 days ago
Based on feedback, I reworked these patches. I've re-presented both as
I realise that one had invalid formatting (spaces vs tabs) and I've
moved the dma-names definition into the same board level dtsi. At this
point it seems reasonable to also squash the two patches, but feedback
appreciated?

The default pinctrl definitions for the Radxa Zero 3W don't match the
datasheet. Possibly few people enable extra UARTs and hence it wasn't
noticed? I needed all 5 UARTs for a project and the first patch corrects
the pinctrl defs. Without this patch, enabling the extra UARTs causes
issues such as the MMC devices disappearing, due to collisions.

Second patch adds a dma-names property, which appears to be a
pre-requisite for enabling DMA on the UARTs. I've applied this to the
board level dts as feedback suggested there could be unintended problems
if enabled across the complete rockchip dtsi.

It's tested on my Zero 3W board and appears to function correctly and
DMA is reported as enabled.

Ed Wildgoose (2):
  arm64: dts: rockchip: correct uart mux for Radxa ZERO 3
  rockchip: dts: Enable UART DMA by adding default dma-names property

 .../dts/rockchip/rk3566-radxa-zero-3.dtsi     | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)

-- 
2.49.0
Re: [PATCH 0/2] arm64: dts: rockchip: fix dma and pinctrl defs v2
Posted by Heiko Stübner 1 week, 6 days ago
Hi Ed,

Am Donnerstag, 18. September 2025, 11:32:44 Mitteleuropäische Sommerzeit schrieb Ed Wildgoose:
> Based on feedback, I reworked these patches. I've re-presented both as
> I realise that one had invalid formatting (spaces vs tabs) and I've
> moved the dma-names definition into the same board level dtsi. At this
> point it seems reasonable to also squash the two patches, but feedback
> appreciated?
> 
> The default pinctrl definitions for the Radxa Zero 3W don't match the
> datasheet. Possibly few people enable extra UARTs and hence it wasn't
> noticed? I needed all 5 UARTs for a project and the first patch corrects
> the pinctrl defs. Without this patch, enabling the extra UARTs causes
> issues such as the MMC devices disappearing, due to collisions.
> 
> Second patch adds a dma-names property, which appears to be a
> pre-requisite for enabling DMA on the UARTs. I've applied this to the
> board level dts as feedback suggested there could be unintended problems
> if enabled across the complete rockchip dtsi.
> 
> It's tested on my Zero 3W board and appears to function correctly and
> DMA is reported as enabled.

housekeeping requests:
- please don't attach new versions to an old thread, but instead
  start a new thread
- this is supposed to be v2, so patches should be named
"[PATCH v2 0/2] ..." etc.

At least the cover-letter should contain a changelog what changed
between versions.


Heiko