sound/soc/qcom/sc8280xp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
All firmware for the Lemans platform aka QCS9100 aka QCS9075 is for
historical reasons located in the qcom/sa8775p/ subdir inside
linux-firmware. The only exceptions to this rule are audio topology
files. While it's not too late, change the subdir to point to the
sa8775p/ subdir, so that all firmware for that platform is present at
the same location.
Fixes: 5b5bf5922f4c ("ASoC: qcom: sc8280xp: Add sound card support for QCS9100 and QCS9075")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
sound/soc/qcom/sc8280xp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
index 73f9f82c4e2581c132e6f6468740a33a6f2ec0c8..0d482d8eb1dd41a3a93d8a6d5cc4b419b8c45dbd 100644
--- a/sound/soc/qcom/sc8280xp.c
+++ b/sound/soc/qcom/sc8280xp.c
@@ -187,8 +187,8 @@ static const struct of_device_id snd_sc8280xp_dt_match[] = {
{.compatible = "qcom,qcm6490-idp-sndcard", "qcm6490"},
{.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"},
{.compatible = "qcom,qcs8275-sndcard", "qcs8275"},
- {.compatible = "qcom,qcs9075-sndcard", "qcs9075"},
- {.compatible = "qcom,qcs9100-sndcard", "qcs9100"},
+ {.compatible = "qcom,qcs9075-sndcard", "sa8775p"},
+ {.compatible = "qcom,qcs9100-sndcard", "sa8775p"},
{.compatible = "qcom,sc8280xp-sndcard", "sc8280xp"},
{.compatible = "qcom,sm8450-sndcard", "sm8450"},
{.compatible = "qcom,sm8550-sndcard", "sm8550"},
---
base-commit: 05af764719214d6568adb55c8749dec295228da8
change-id: 20250918-lemans-evk-topo-dddd73c29024
Best regards,
--
With best wishes
Dmitry
On Thu, Sep 18, 2025 at 05:41:52AM +0300, Dmitry Baryshkov wrote: > All firmware for the Lemans platform aka QCS9100 aka QCS9075 is for > historical reasons located in the qcom/sa8775p/ subdir inside > linux-firmware. The only exceptions to this rule are audio topology > files. While it's not too late, change the subdir to point to the > sa8775p/ subdir, so that all firmware for that platform is present at > the same location. This doesn't apply against current code, please check and resend.
On Thu, Sep 18, 2025 at 05:41:52AM +0300, Dmitry Baryshkov wrote: > All firmware for the Lemans platform aka QCS9100 aka QCS9075 is for > historical reasons located in the qcom/sa8775p/ subdir inside > linux-firmware. The only exceptions to this rule are audio topology > files. While it's not too late, change the subdir to point to the > sa8775p/ subdir, so that all firmware for that platform is present at > the same location. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On 9/18/2025 8:11 AM, Dmitry Baryshkov wrote: > All firmware for the Lemans platform aka QCS9100 aka QCS9075 is for > historical reasons located in the qcom/sa8775p/ subdir inside > linux-firmware. The only exceptions to this rule are audio topology > files. While it's not too late, change the subdir to point to the > sa8775p/ subdir, so that all firmware for that platform is present at > the same location. > > Fixes: 5b5bf5922f4c ("ASoC: qcom: sc8280xp: Add sound card support for QCS9100 and QCS9075") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- > sound/soc/qcom/sc8280xp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > LGTM, Acked-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com> > diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c > index 73f9f82c4e2581c132e6f6468740a33a6f2ec0c8..0d482d8eb1dd41a3a93d8a6d5cc4b419b8c45dbd 100644 > --- a/sound/soc/qcom/sc8280xp.c > +++ b/sound/soc/qcom/sc8280xp.c > @@ -187,8 +187,8 @@ static const struct of_device_id snd_sc8280xp_dt_match[] = { > {.compatible = "qcom,qcm6490-idp-sndcard", "qcm6490"}, > {.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"}, > {.compatible = "qcom,qcs8275-sndcard", "qcs8275"}, > - {.compatible = "qcom,qcs9075-sndcard", "qcs9075"}, > - {.compatible = "qcom,qcs9100-sndcard", "qcs9100"}, > + {.compatible = "qcom,qcs9075-sndcard", "sa8775p"}, > + {.compatible = "qcom,qcs9100-sndcard", "sa8775p"}, > {.compatible = "qcom,sc8280xp-sndcard", "sc8280xp"}, > {.compatible = "qcom,sm8450-sndcard", "sm8450"}, > {.compatible = "qcom,sm8550-sndcard", "sm8550"}, > > --- > base-commit: 05af764719214d6568adb55c8749dec295228da8 > change-id: 20250918-lemans-evk-topo-dddd73c29024 > > Best regards,
© 2016 - 2025 Red Hat, Inc.