broadcom: report the supported flags for ancillary features

[PATCH net 0/3] broadcom: report the supported flags for ancillary features

Posted by Jacob Keller 1 week, 6 days ago

James Clark reported off list that the broadcom PHY PTP driver was
incorrectly handling PTP_EXTTS_REQUEST and PTP_PEROUT_REQUEST ioctls since
the conversion to the .supported_*_flags fields. This series fixes the
driver to correctly report its flags through the .supported_perout_flags
and .supported_extts_flags fields. It also contains an update to comment
the behavior of the PTP_STRICT_FLAGS being always enabled for
PTP_EXTTS_REQUEST2.

I plan to follow up this series with some improvements to the PTP
documentation better explaining each flag and the expectation of the driver
APIs.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
Jacob Keller (3):
      broadcom: fix support for PTP_PEROUT_DUTY_CYCLE
      broadcom: fix support for PTP_EXTTS_REQUEST2 ioctl
      ptp: document behavior of PTP_STRICT_FLAGS

 include/uapi/linux/ptp_clock.h | 3 +++
 drivers/net/phy/bcm-phy-ptp.c  | 6 ++----
 2 files changed, 5 insertions(+), 4 deletions(-)
---
base-commit: cbf658dd09419f1ef9de11b9604e950bdd5c170b
change-id: 20250918-jk-fix-bcm-phy-supported-flags-0796dddf7954

Best regards,
--  
Jacob Keller <jacob.e.keller@intel.com>

Re: [PATCH net 0/3] broadcom: report the supported flags for ancillary features

Posted by Jakub Kicinski 1 week, 5 days ago

On Thu, 18 Sep 2025 17:33:15 -0700 Jacob Keller wrote:
> James Clark reported off list that the broadcom PHY PTP driver was
> incorrectly handling PTP_EXTTS_REQUEST and PTP_PEROUT_REQUEST ioctls since
> the conversion to the .supported_*_flags fields. This series fixes the
> driver to correctly report its flags through the .supported_perout_flags
> and .supported_extts_flags fields. It also contains an update to comment
> the behavior of the PTP_STRICT_FLAGS being always enabled for
> PTP_EXTTS_REQUEST2.

James, would you be willing to test and send an official Tested-by tag?

Re: [PATCH net 0/3] broadcom: report the supported flags for ancillary features

Posted by James Clark 1 week, 4 days ago

On Sat, Sep 20, 2025 at 7:04 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu, 18 Sep 2025 17:33:15 -0700 Jacob Keller wrote:
> > James Clark reported off list that the broadcom PHY PTP driver was
> > incorrectly handling PTP_EXTTS_REQUEST and PTP_PEROUT_REQUEST ioctls since
> > the conversion to the .supported_*_flags fields. This series fixes the
> > driver to correctly report its flags through the .supported_perout_flags
> > and .supported_extts_flags fields. It also contains an update to comment
> > the behavior of the PTP_STRICT_FLAGS being always enabled for
> > PTP_EXTTS_REQUEST2.
>
> James, would you be willing to test and send an official Tested-by tag?

I have tested this on a Raspberry Pi CM4: PTP_EXTTS_REQUEST2 and
PTP_PEROUT_REQUEST2 both work. Thanks!

Going forward, I have got myself setup to be able to build and install
a vanilla kernel on a CM4, so if there is stuff that needs testing on
bcm-phy-ptp, just Cc me.

Tested-by: James Clark <jjc@jclark.com>

Re: [PATCH net 0/3] broadcom: report the supported flags for ancillary features

Posted by Kory Maincent 1 week, 5 days ago

On Thu, 18 Sep 2025 17:33:15 -0700
Jacob Keller <jacob.e.keller@intel.com> wrote:

> James Clark reported off list that the broadcom PHY PTP driver was
> incorrectly handling PTP_EXTTS_REQUEST and PTP_PEROUT_REQUEST ioctls since
> the conversion to the .supported_*_flags fields. This series fixes the
> driver to correctly report its flags through the .supported_perout_flags
> and .supported_extts_flags fields. It also contains an update to comment
> the behavior of the PTP_STRICT_FLAGS being always enabled for
> PTP_EXTTS_REQUEST2.
> 
> I plan to follow up this series with some improvements to the PTP
> documentation better explaining each flag and the expectation of the driver
> APIs.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>

Thank you!
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH net 0/3] broadcom: report the supported flags for ancillary features

Posted by Richard Cochran 1 week, 6 days ago

On Thu, Sep 18, 2025 at 05:33:15PM -0700, Jacob Keller wrote:
> James Clark reported off list that the broadcom PHY PTP driver was
> incorrectly handling PTP_EXTTS_REQUEST and PTP_PEROUT_REQUEST ioctls since
> the conversion to the .supported_*_flags fields. This series fixes the
> driver to correctly report its flags through the .supported_perout_flags
> and .supported_extts_flags fields. It also contains an update to comment
> the behavior of the PTP_STRICT_FLAGS being always enabled for
> PTP_EXTTS_REQUEST2.
> 
> I plan to follow up this series with some improvements to the PTP
> documentation better explaining each flag and the expectation of the driver
> APIs.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

For series:

Acked-by: Richard Cochran <richardcochran@gmail.com>