Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml | 1 + 1 file changed, 1 insertion(+)
DT validation will report missing type definition warning for the property of
'ps-cancellation-current-picoamp', explicitly add type definition to fix it.
Signed-off-by: Yixun Lan <dlan@gentoo.org>
---
I got following DT warning, when running dtbs_check
$ make ARCH=riscv CROSS_COMPILE=riscv64-unknown-linux-gnu- dtbs_check W=1
generic check all files
UPD include/config/kernel.release
SCHEMA Documentation/devicetree/bindings/processed-schema.json
/home/work/linux-6.y/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml: ps-cancellation-current-picoamp: missing type definition
---
Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml b/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
index bb1cc4404a55760d3f2ef3818d8f5c14782dc5b8..f9c35c29fe04c3623349b636a0dd7ffa4ea24a14 100644
--- a/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
+++ b/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
@@ -37,6 +37,7 @@ properties:
maximum: 63
ps-cancellation-current-picoamp:
+ $ref: /schemas/types.yaml#/definitions/uint32
description:
Proximity sensor crosstalk cancellation current in picoampere.
This parameter adjusts the current in steps of 2400 pA up to 276000 pA.
---
base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
change-id: 20250918-60-dt-iio-apds9160-bdb725db100d
Best regards,
--
Yixun Lan
On Thu, Sep 18, 2025 at 05:02:01AM +0800, Yixun Lan wrote: > DT validation will report missing type definition warning for the property of > 'ps-cancellation-current-picoamp', explicitly add type definition to fix it. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 And no, this is wrong. You use some outdated dtschema. Best regards, Krzysztof
On Thu, 18 Sep 2025 05:02:01 +0800, Yixun Lan wrote: > DT validation will report missing type definition warning for the property of > 'ps-cancellation-current-picoamp', explicitly add type definition to fix it. > > Signed-off-by: Yixun Lan <dlan@gentoo.org> > --- > I got following DT warning, when running dtbs_check > > $ make ARCH=riscv CROSS_COMPILE=riscv64-unknown-linux-gnu- dtbs_check W=1 > generic check all files > UPD include/config/kernel.release > SCHEMA Documentation/devicetree/bindings/processed-schema.json > /home/work/linux-6.y/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml: ps-cancellation-current-picoamp: missing type definition > --- > Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/light/brcm,apds9160.example.dtb: light-sensor@53 (brcm,apds9160): ps-cancellation-current-picoamp: 62400 is not of type 'array' from schema $id: http://devicetree.org/schemas/property-units.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250918-60-dt-iio-apds9160-v1-1-0bd6bcbc547d@gentoo.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 9/17/25 4:02 PM, Yixun Lan wrote: > DT validation will report missing type definition warning for the property of > 'ps-cancellation-current-picoamp', explicitly add type definition to fix it. > > Signed-off-by: Yixun Lan <dlan@gentoo.org> > --- > I got following DT warning, when running dtbs_check > > $ make ARCH=riscv CROSS_COMPILE=riscv64-unknown-linux-gnu- dtbs_check W=1 > generic check all files > UPD include/config/kernel.release > SCHEMA Documentation/devicetree/bindings/processed-schema.json > /home/work/linux-6.y/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml: ps-cancellation-current-picoamp: missing type definition > --- > Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml b/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml > index bb1cc4404a55760d3f2ef3818d8f5c14782dc5b8..f9c35c29fe04c3623349b636a0dd7ffa4ea24a14 100644 > --- a/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml > +++ b/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml > @@ -37,6 +37,7 @@ properties: > maximum: 63 > > ps-cancellation-current-picoamp: > + $ref: /schemas/types.yaml#/definitions/uint32 `-picoamp` is already a standard property suffix [1]. Git blame says it was added 8 months ago, so maybe you haven't updated dtschema in a while? [1]: https://github.com/devicetree-org/dt-schema/blob/4b28bc79fdc552f3e0b870ef1362bb711925f4f3/dtschema/schemas/property-units.yaml#L92 > description: > Proximity sensor crosstalk cancellation current in picoampere. > This parameter adjusts the current in steps of 2400 pA up to 276000 pA. > > --- > base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585 > change-id: 20250918-60-dt-iio-apds9160-bdb725db100d > > Best regards,
© 2016 - 2025 Red Hat, Inc.