[PATCH 1/4] hwmon: (dell-smm) Remove Dell Precision 490 custom config data

Armin Wolf posted 4 patches 2 weeks ago
[PATCH 1/4] hwmon: (dell-smm) Remove Dell Precision 490 custom config data
Posted by Armin Wolf 2 weeks ago
It turns out the second fan on the Dell Precision 490 does not
really support I8K_FAN_TURBO. Setting the fan state to 3 enables
automatic fan control, just like on the other two fans.
The reason why this was misinterpreted as turbo mode was that
the second fan normally spins faster in automatic mode than
in the previous fan states. Yet when in state 3, the fan speed
reacts to heat exposure, exposing the automatic mode setting.

Link: https://github.com/lm-sensors/lm-sensors/pull/383
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
 drivers/hwmon/dell-smm-hwmon.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 1e2c8e284001..3f61b2d7935e 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1331,7 +1331,6 @@ struct i8k_config_data {
 
 enum i8k_configs {
 	DELL_LATITUDE_D520,
-	DELL_PRECISION_490,
 	DELL_STUDIO,
 	DELL_XPS,
 };
@@ -1341,10 +1340,6 @@ static const struct i8k_config_data i8k_config_data[] __initconst = {
 		.fan_mult = 1,
 		.fan_max = I8K_FAN_TURBO,
 	},
-	[DELL_PRECISION_490] = {
-		.fan_mult = 1,
-		.fan_max = I8K_FAN_TURBO,
-	},
 	[DELL_STUDIO] = {
 		.fan_mult = 1,
 		.fan_max = I8K_FAN_HIGH,
@@ -1364,15 +1359,6 @@ static const struct dmi_system_id i8k_config_dmi_table[] __initconst = {
 		},
 		.driver_data = (void *)&i8k_config_data[DELL_LATITUDE_D520],
 	},
-	{
-		.ident = "Dell Precision 490",
-		.matches = {
-			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
-			DMI_MATCH(DMI_PRODUCT_NAME,
-				  "Precision WorkStation 490"),
-		},
-		.driver_data = (void *)&i8k_config_data[DELL_PRECISION_490],
-	},
 	{
 		.ident = "Dell Studio",
 		.matches = {
-- 
2.39.5
Re: [PATCH 1/4] hwmon: (dell-smm) Remove Dell Precision 490 custom config data
Posted by Guenter Roeck 1 week ago
On Wed, Sep 17, 2025 at 08:10:33PM +0200, Armin Wolf wrote:
> It turns out the second fan on the Dell Precision 490 does not
> really support I8K_FAN_TURBO. Setting the fan state to 3 enables
> automatic fan control, just like on the other two fans.
> The reason why this was misinterpreted as turbo mode was that
> the second fan normally spins faster in automatic mode than
> in the previous fan states. Yet when in state 3, the fan speed
> reacts to heat exposure, exposing the automatic mode setting.
> 
> Link: https://github.com/lm-sensors/lm-sensors/pull/383
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>

Applied.
Guenter