[PATCH v13 8/9] cpumask: Add initialiser to use cleanup helpers

Gabriele Monaco posted 9 patches 2 weeks ago
[PATCH v13 8/9] cpumask: Add initialiser to use cleanup helpers
Posted by Gabriele Monaco 2 weeks ago
From: Yury Norov <yury.norov@gmail.com>

Now we can simplify a code that allocates cpumasks for local needs.

Automatic variables have to be initialized at declaration, or at least
before any possibility for the logic to return, so that compiler
wouldn't try to call an associate destructor function on a random stack
number.

Because cpumask_var_t, depending on the CPUMASK_OFFSTACK config, is
either a pointer or an array, we have to have a macro for initialization.

So define a CPUMASK_VAR_NULL macro, which allows to init struct cpumask
pointer with NULL when CPUMASK_OFFSTACK is enabled, and effectively a
no-op when CPUMASK_OFFSTACK is disabled.

Signed-off-by: Yury Norov <yury.norov@gmail.com>
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
 include/linux/cpumask.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h
index ff8f41ab7ce6..68be522449ec 100644
--- a/include/linux/cpumask.h
+++ b/include/linux/cpumask.h
@@ -1005,6 +1005,7 @@ static __always_inline unsigned int cpumask_size(void)
 
 #define this_cpu_cpumask_var_ptr(x)	this_cpu_read(x)
 #define __cpumask_var_read_mostly	__read_mostly
+#define CPUMASK_VAR_NULL		NULL
 
 bool alloc_cpumask_var_node(cpumask_var_t *mask, gfp_t flags, int node);
 
@@ -1051,6 +1052,7 @@ static __always_inline bool cpumask_available(cpumask_var_t mask)
 
 #define this_cpu_cpumask_var_ptr(x) this_cpu_ptr(x)
 #define __cpumask_var_read_mostly
+#define CPUMASK_VAR_NULL {}
 
 static __always_inline bool alloc_cpumask_var(cpumask_var_t *mask, gfp_t flags)
 {
-- 
2.51.0
Re: [PATCH v13 8/9] cpumask: Add initialiser to use cleanup helpers
Posted by Frederic Weisbecker 2 weeks ago
Le Wed, Sep 17, 2025 at 06:19:57PM +0200, Gabriele Monaco a écrit :
> From: Yury Norov <yury.norov@gmail.com>
> 
> Now we can simplify a code that allocates cpumasks for local needs.
> 
> Automatic variables have to be initialized at declaration, or at least
> before any possibility for the logic to return, so that compiler
> wouldn't try to call an associate destructor function on a random stack
> number.
> 
> Because cpumask_var_t, depending on the CPUMASK_OFFSTACK config, is
> either a pointer or an array, we have to have a macro for initialization.
> 
> So define a CPUMASK_VAR_NULL macro, which allows to init struct cpumask
> pointer with NULL when CPUMASK_OFFSTACK is enabled, and effectively a
> no-op when CPUMASK_OFFSTACK is disabled.
> 
> Signed-off-by: Yury Norov <yury.norov@gmail.com>
> Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>

Reviewed-by: Frederic Weisbecker <frederic@kernel.org>

-- 
Frederic Weisbecker
SUSE Labs