1. Patchew
  2. linux
  3. View series

[PATCH RESEND] sparc: PCI: Replace deprecated strcpy() with strscpy()

Thorsten Blum posted 1 patch 2 weeks ago 
arch/sparc/kernel/pcic.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
[PATCH RESEND] sparc: PCI: Replace deprecated strcpy() with strscpy()
Posted by Thorsten Blum 2 weeks ago 
strcpy() is deprecated; use strscpy() instead.

No functional changes intended.

Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 arch/sparc/kernel/pcic.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/sparc/kernel/pcic.c b/arch/sparc/kernel/pcic.c
index 25fe0a061732..f894ae79e78a 100644
--- a/arch/sparc/kernel/pcic.c
+++ b/arch/sparc/kernel/pcic.c
@@ -16,6 +16,7 @@
 #include <linux/init.h>
 #include <linux/mm.h>
 #include <linux/slab.h>
+#include <linux/string.h>
 #include <linux/jiffies.h>
 
 #include <asm/swift.h> /* for cache flushing. */
@@ -352,7 +353,7 @@ int __init pcic_probe(void)
 	pbm = &pcic->pbm;
 	pbm->prom_node = node;
 	prom_getstring(node, "name", namebuf, 63);  namebuf[63] = 0;
-	strcpy(pbm->prom_name, namebuf);
+	strscpy(pbm->prom_name, namebuf);
 
 	{
 		extern int pcic_nmi_trap_patch[4];
@@ -477,7 +478,7 @@ static void pcic_map_pci_device(struct linux_pcic *pcic,
 	int j;
 
 	if (node == 0 || node == -1) {
-		strcpy(namebuf, "???");
+		strscpy(namebuf, "???");
 	} else {
 		prom_getstring(node, "name", namebuf, 63); namebuf[63] = 0;
 	}
@@ -536,7 +537,7 @@ pcic_fill_irq(struct linux_pcic *pcic, struct pci_dev *dev, int node)
 	char namebuf[64];
 
 	if (node == 0 || node == -1) {
-		strcpy(namebuf, "???");
+		strscpy(namebuf, "???");
 	} else {
 		prom_getstring(node, "name", namebuf, sizeof(namebuf));
 	}
-- 
2.51.0
Re: [PATCH RESEND] sparc: PCI: Replace deprecated strcpy() with strscpy()
Posted by Bjorn Helgaas 2 weeks ago 
On Wed, Sep 17, 2025 at 04:47:30PM +0200, Thorsten Blum wrote:
> strcpy() is deprecated; use strscpy() instead.
> 
> No functional changes intended.
> 
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

No objection from me, but no particular PCI core issue and I don't
maintain this file, so up to the sparc folks if they want it.

I would consider making a single patch to address this issue
everywhere in arch/sparc so it can all be reviewed together.

> ---
>  arch/sparc/kernel/pcic.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/sparc/kernel/pcic.c b/arch/sparc/kernel/pcic.c
> index 25fe0a061732..f894ae79e78a 100644
> --- a/arch/sparc/kernel/pcic.c
> +++ b/arch/sparc/kernel/pcic.c
> @@ -16,6 +16,7 @@
>  #include <linux/init.h>
>  #include <linux/mm.h>
>  #include <linux/slab.h>
> +#include <linux/string.h>
>  #include <linux/jiffies.h>
>  
>  #include <asm/swift.h> /* for cache flushing. */
> @@ -352,7 +353,7 @@ int __init pcic_probe(void)
>  	pbm = &pcic->pbm;
>  	pbm->prom_node = node;
>  	prom_getstring(node, "name", namebuf, 63);  namebuf[63] = 0;
> -	strcpy(pbm->prom_name, namebuf);
> +	strscpy(pbm->prom_name, namebuf);
>  
>  	{
>  		extern int pcic_nmi_trap_patch[4];
> @@ -477,7 +478,7 @@ static void pcic_map_pci_device(struct linux_pcic *pcic,
>  	int j;
>  
>  	if (node == 0 || node == -1) {
> -		strcpy(namebuf, "???");
> +		strscpy(namebuf, "???");
>  	} else {
>  		prom_getstring(node, "name", namebuf, 63); namebuf[63] = 0;
>  	}
> @@ -536,7 +537,7 @@ pcic_fill_irq(struct linux_pcic *pcic, struct pci_dev *dev, int node)
>  	char namebuf[64];
>  
>  	if (node == 0 || node == -1) {
> -		strcpy(namebuf, "???");
> +		strscpy(namebuf, "???");
>  	} else {
>  		prom_getstring(node, "name", namebuf, sizeof(namebuf));
>  	}
> -- 
> 2.51.0
>
Re: [PATCH RESEND] sparc: PCI: Replace deprecated strcpy() with strscpy()
Posted by Andreas Larsson 1 week, 5 days ago 
On 2025-09-17 17:50, Bjorn Helgaas wrote:
> On Wed, Sep 17, 2025 at 04:47:30PM +0200, Thorsten Blum wrote:
>> strcpy() is deprecated; use strscpy() instead.
>>
>> No functional changes intended.
>>
>> Link: https://github.com/KSPP/linux/issues/88
>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> 
> No objection from me, but no particular PCI core issue and I don't
> maintain this file, so up to the sparc folks if they want it.
> 
> I would consider making a single patch to address this issue
> everywhere in arch/sparc so it can all be reviewed together.

Thank you and sorry for the late feedback. I agree with the above.
Thorsten, could you fix this for all occurrences of strcpy() in
arch/sparc?

Thanks,
Andreas
Re: [PATCH RESEND] sparc: PCI: Replace deprecated strcpy() with strscpy()
Posted by Thorsten Blum 1 week, 2 days ago 
Hi Andreas,

On 19. Sep 2025, Andreas Larsson wrote:
> 
> 
> On 2025-09-17 17:50, Bjorn Helgaas wrote:
>> On Wed, Sep 17, 2025 at 04:47:30PM +0200, Thorsten Blum wrote:
>>> strcpy() is deprecated; use strscpy() instead.
>>> 
>>> No functional changes intended.
>>> 
>>> Link: https://github.com/KSPP/linux/issues/88
>>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>> 
>> No objection from me, but no particular PCI core issue and I don't
>> maintain this file, so up to the sparc folks if they want it.
>> 
>> I would consider making a single patch to address this issue
>> everywhere in arch/sparc so it can all be reviewed together.
> 
> Thank you and sorry for the late feedback. I agree with the above.
> Thorsten, could you fix this for all occurrences of strcpy() in
> arch/sparc?

I just submitted a small series [1] replacing all occurrences of strcpy
in arch/sparc.

Thanks,
Thorsten

[1] https://lore.kernel.org/lkml/20250922210408.1723452-1-thorsten.blum@linux.dev/

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.