Hello maintainers,
This patch series fixes 18 errors reported by checkpatch.pl on
drivers/i2c/algos/i2c-algo-pcf.c file.
The series PATCH v1 to PATCH v4 is a response to the discussion on the mailing
list with Markus Elfring who had comments on my earlier submissions.
He suggested:
-to split my initial submission in a patch series
-had some valid points on imperative mood usage in commit messages
-wrapping commit message to 75 columns per line
-change some of the commit message to point usage of checkpatch.pl
Here is a brief summary and order of patches to be applied:
Patch 1/3: i2c: pcf8584: Fix debug macros defines of if statements
This patch encloses the debug macro defines of if statements in do-while
loops.
Patch 2/3: i2c: pcf8584: Fix do not use assignment inside if conditional
This patch takes the assignement from if conditional and moves it by 1 line
up.
Patch 3/3: i2c: pcf8584: Fix space(s) required before or after different
operators
This patch adds space(s) around, before or after some binary operators
and punctuation marks.
Testing:
*built kernel and modules with I2C_ALGOPCF=m and my 3 patches applied on
top of 6.17.0-rc6.
*installed kernel and external modules generated by build on my laptop
*rebooted and loaded i2c-algo-pcf.ko with param i2c_debug=2/3/9.
*No success message related to i2c_algo_pcf was seen in dmesg but also no
errors.
*Module loading and unloading successful.
*No PCF8584 Hardware was available.
Patches 1 and 3 report 4 and 6 warnings when running checkpatch on them.
They appeared because of two errors/warnings on the same line of code.
But the warnings will be fixed in a new patchset that addresses fixing
warnings.
Cezar Chiru (3):
i2c: pcf8584: Fix debug macros defines of if statements
i2c: pcf8584: Fix do not use assignment inside if conditional
i2c: pcf8584: Fix space(s) required before or after different
operators
drivers/i2c/algos/i2c-algo-pcf.c | 62 ++++++++++++++++++++------------
1 file changed, 39 insertions(+), 23 deletions(-)
--
2.43.0