Add 'resets' and 'reset-names' properties for SMI LARBs to support
SMI reset operations.
On the MediaTek platform, some SMI LARBs are directly connected to
the SMI Common, while others are connected to the SMI Sub-Common,
which in turn is connected to the SMI Common. The hardware block
diagram can be described as follows.
SMI-Common(Smart Multimedia Interface Common)
|
+----------------+------------------+
| | |
| | |
| | |
| | |
| | |
larb0 SMI-Sub-Common0 SMI-Sub-Common1
| | | | |
larb1 larb2 larb3 larb7 larb9
Signed-off-by: Friday Yang <friday.yang@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Rob Herring <robh@kernel.org>
---
.../mediatek,smi-common.yaml | 2 ++
.../memory-controllers/mediatek,smi-larb.yaml | 19 +++++++++++++++++++
2 files changed, 21 insertions(+)
diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
index 0762e0ff66ef..3d98c08b2149 100644
--- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
@@ -40,6 +40,7 @@ properties:
- mediatek,mt8186-smi-common
- mediatek,mt8188-smi-common-vdo
- mediatek,mt8188-smi-common-vpp
+ - mediatek,mt8188-smi-sub-common
- mediatek,mt8192-smi-common
- mediatek,mt8195-smi-common-vdo
- mediatek,mt8195-smi-common-vpp
@@ -108,6 +109,7 @@ allOf:
compatible:
contains:
enum:
+ - mediatek,mt8188-smi-sub-common
- mediatek,mt8195-smi-sub-common
then:
required:
diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
index 2e7fac4b5094..fc5feb2eac1f 100644
--- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
@@ -70,6 +70,12 @@ properties:
description: the hardware id of this larb. It's only required when this
hardware id is not consecutive from its M4U point of view.
+ resets:
+ maxItems: 1
+
+ reset-names:
+ const: larb
+
required:
- compatible
- reg
@@ -126,6 +132,19 @@ allOf:
required:
- mediatek,larb-id
+ - if: # only for image, camera and ipe subsys
+ properties:
+ compatible:
+ const: mediatek,mt8188-smi-larb
+ mediatek,larb-id:
+ enum:
+ [ 9, 10, 11, 12, 13, 16, 17, 18, 19, 20 ]
+
+ then:
+ required:
+ - resets
+ - reset-names
+
additionalProperties: false
examples:
--
2.46.0On 17/09/2025 14:07, Friday Yang wrote: > Add 'resets' and 'reset-names' properties for SMI LARBs to support > SMI reset operations. Not informative... > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > index 2e7fac4b5094..fc5feb2eac1f 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > @@ -70,6 +70,12 @@ properties: > description: the hardware id of this larb. It's only required when this > hardware id is not consecutive from its M4U point of view. > > + resets: > + maxItems: 1 > + > + reset-names: > + const: larb Is the reset valid for all existing devices as well? Commit msg does not explain that... it is pretty useless - you say what you did. We see that from the diff. Explain something not obvious. Best regards, Krzysztof
On Sat, 2025-10-18 at 18:42 +0200, Krzysztof Kozlowski wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 17/09/2025 14:07, Friday Yang wrote: > > Add 'resets' and 'reset-names' properties for SMI LARBs to support > > SMI reset operations. > > Not informative... > > > diff --git a/Documentation/devicetree/bindings/memory- > > controllers/mediatek,smi-larb.yaml > > b/Documentation/devicetree/bindings/memory- > > controllers/mediatek,smi-larb.yaml > > index 2e7fac4b5094..fc5feb2eac1f 100644 > > --- a/Documentation/devicetree/bindings/memory- > > controllers/mediatek,smi-larb.yaml > > +++ b/Documentation/devicetree/bindings/memory- > > controllers/mediatek,smi-larb.yaml > > @@ -70,6 +70,12 @@ properties: > > description: the hardware id of this larb. It's only required > > when this > > hardware id is not consecutive from its M4U point of view. > > > > + resets: > > + maxItems: 1 > > + > > + reset-names: > > + const: larb > > Is the reset valid for all existing devices as well? Commit msg does > not > explain that... it is pretty useless - you say what you did. We see > that > from the diff. Explain something not obvious. > Thanks, I could add more descriptions here, like below: On the MediaTek MT8188 SoC, bus glitches may occur during MTCMOS on/off transitions. To prevent these glitches from causing errors, SMI requires clamp and reset operations. This issue specifically affects the image, camera, and IPE subsystems. This change adds the 'resets' and 'reset-names' properties to the SMI LARBs within these subsystems to support the necessary reset operations. ... Can I still remain the 'Reviewed-by' and 'Acked-by' tags if I only change the commit mesg in v12? I will not change the bindings. > > > Best regards, > Krzysztof
On 31/10/2025 07:10, Friday Yang (杨阳) wrote: > On Sat, 2025-10-18 at 18:42 +0200, Krzysztof Kozlowski wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On 17/09/2025 14:07, Friday Yang wrote: >>> Add 'resets' and 'reset-names' properties for SMI LARBs to support >>> SMI reset operations. >> >> Not informative... >> >>> diff --git a/Documentation/devicetree/bindings/memory- >>> controllers/mediatek,smi-larb.yaml >>> b/Documentation/devicetree/bindings/memory- >>> controllers/mediatek,smi-larb.yaml >>> index 2e7fac4b5094..fc5feb2eac1f 100644 >>> --- a/Documentation/devicetree/bindings/memory- >>> controllers/mediatek,smi-larb.yaml >>> +++ b/Documentation/devicetree/bindings/memory- >>> controllers/mediatek,smi-larb.yaml >>> @@ -70,6 +70,12 @@ properties: >>> description: the hardware id of this larb. It's only required >>> when this >>> hardware id is not consecutive from its M4U point of view. >>> >>> + resets: >>> + maxItems: 1 >>> + >>> + reset-names: >>> + const: larb >> >> Is the reset valid for all existing devices as well? Commit msg does >> not >> explain that... it is pretty useless - you say what you did. We see >> that >> from the diff. Explain something not obvious. >> > > Thanks, I could add more descriptions here, like below: > > On the MediaTek MT8188 SoC, bus glitches may occur during MTCMOS > on/off transitions. To prevent these glitches from causing errors, > SMI requires clamp and reset operations. This issue specifically > affects the image, camera, and IPE subsystems. This explains why you need it. But I asked more questions than only "whY". Read the question: "Is the reset valid for all existing devices as well?" Where is the answer for that? I still do not know... Do not reply to only pieces of review. > This change adds the > 'resets' and 'reset-names' properties to the SMI LARBs within > these subsystems to support the necessary reset operations. Read again my message: " it is pretty useless - you say what you did" That's the same, drop. So again you just cared to implement only piece of review. Best regards, Krzysztof
© 2016 - 2026 Red Hat, Inc.