staging: rtl8723bs: xmit: fix grammar in comment

[PATCH] staging: rtl8723bs: xmit: fix grammar in comment

Posted by Akiyoshi Kurita 4 months, 3 weeks ago

Fix 'number of page' -> 'number of pages' in a comment.

Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
---
 drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index 842e19b53421..7ba8981f4652 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -76,7 +76,7 @@ static s32 rtl8723_dequeue_writeport(struct adapter *padapter)
 	/*  check if hardware tx fifo page is enough */
 	if (!rtw_hal_sdio_query_tx_freepage(pri_padapter, PageIdx, pxmitbuf->pg_num)) {
 		if (!bUpdatePageNum) {
-			/*  Total number of page is NOT available, so update current FIFO status */
+			/*  Total number of pages is NOT available, so update current FIFO status */
 			HalQueryTxBufferStatus8723BSdio(padapter);
 			bUpdatePageNum = true;
 			goto query_free_page;
-- 
2.47.3

Re: [PATCH] staging: rtl8723bs: xmit: fix grammar in comment

Posted by Greg KH 4 months, 3 weeks ago

On Wed, Sep 17, 2025 at 02:39:44PM +0900, Akiyoshi Kurita wrote:
> Fix 'number of page' -> 'number of pages' in a comment.
> 
> Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> index 842e19b53421..7ba8981f4652 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> @@ -76,7 +76,7 @@ static s32 rtl8723_dequeue_writeport(struct adapter *padapter)
>  	/*  check if hardware tx fifo page is enough */
>  	if (!rtw_hal_sdio_query_tx_freepage(pri_padapter, PageIdx, pxmitbuf->pg_num)) {
>  		if (!bUpdatePageNum) {
> -			/*  Total number of page is NOT available, so update current FIFO status */
> +			/*  Total number of pages is NOT available, so update current FIFO status */

As "pages" is now plural, shouldn't "is" become "are"?

Also, you can drop the extra leading space in the comment.

thanks,

greg "english grammer is rough" k-h

Re: [PATCH] staging: rtl8723bs: xmit: fix grammar in comment

Posted by weibu@redadmin.org 4 months, 3 weeks ago

Thanks, Greg.

Sorry for the off-list reply; resending to the lists.
You're right about the extra space; I dropped it. To avoid the "number 
of"
confusion I rephrased the sentence to "Total page count is not 
available, so
update current FIFO status." Sent as v2.

Best,
Akiyoshi

2025-09-17 14:52 に Greg KH さんは書きました:
> On Wed, Sep 17, 2025 at 02:39:44PM +0900, Akiyoshi Kurita wrote:
>> Fix 'number of page' -> 'number of pages' in a comment.
>> 
>> Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
>> ---
>>  drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c 
>> b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
>> index 842e19b53421..7ba8981f4652 100644
>> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
>> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
>> @@ -76,7 +76,7 @@ static s32 rtl8723_dequeue_writeport(struct adapter 
>> *padapter)
>>  	/*  check if hardware tx fifo page is enough */
>>  	if (!rtw_hal_sdio_query_tx_freepage(pri_padapter, PageIdx, 
>> pxmitbuf->pg_num)) {
>>  		if (!bUpdatePageNum) {
>> -			/*  Total number of page is NOT available, so update current FIFO 
>> status */
>> +			/*  Total number of pages is NOT available, so update current FIFO 
>> status */
> 
> As "pages" is now plural, shouldn't "is" become "are"?
> 
> Also, you can drop the extra leading space in the comment.
> 
> thanks,
> 
> greg "english grammer is rough" k-h

[PATCH v2] staging: rtl8723bs: xmit: rephrase comment and drop extra space

Posted by Akiyoshi Kurita 4 months, 3 weeks ago

Rephrase the comment to avoid the "number of" construction and remove
an extra leading space.

Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
---
 drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index 842e19b53421..abb6fdfe7e1f 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -76,7 +76,7 @@ static s32 rtl8723_dequeue_writeport(struct adapter *padapter)
 	/*  check if hardware tx fifo page is enough */
 	if (!rtw_hal_sdio_query_tx_freepage(pri_padapter, PageIdx, pxmitbuf->pg_num)) {
 		if (!bUpdatePageNum) {
-			/*  Total number of page is NOT available, so update current FIFO status */
+			/* Total page count is not available, so update current FIFO status */
 			HalQueryTxBufferStatus8723BSdio(padapter);
 			bUpdatePageNum = true;
 			goto query_free_page;
-- 
2.47.3