[PATCH 11/25] dts: unisoc: rda8810pl: Enable clock/reset driver

Dang Huynh via B4 Relay posted 25 patches 2 weeks, 1 day ago
[PATCH 11/25] dts: unisoc: rda8810pl: Enable clock/reset driver
Posted by Dang Huynh via B4 Relay 2 weeks, 1 day ago
From: Dang Huynh <dang.huynh@mainlining.org>

Enable RDA8810PL Clock and Reset driver so we can use it for various
subsystems.

Signed-off-by: Dang Huynh <dang.huynh@mainlining.org>
---
 arch/arm/boot/dts/unisoc/rda8810pl.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/unisoc/rda8810pl.dtsi b/arch/arm/boot/dts/unisoc/rda8810pl.dtsi
index 45a2fd3e04cea5aac4fb6b40a6b332ce3eee4f2c..1f7a6908d68367441e5dc865216cc7a5c39feb35 100644
--- a/arch/arm/boot/dts/unisoc/rda8810pl.dtsi
+++ b/arch/arm/boot/dts/unisoc/rda8810pl.dtsi
@@ -8,6 +8,7 @@
 
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/clock/rda,8810pl-apclk.h>
 
 / {
 	compatible = "rda,8810pl";
@@ -79,6 +80,13 @@ apb@20900000 {
 		#size-cells = <1>;
 		ranges = <0x0 0x20900000 0x100000>;
 
+		ap_syscon: syscon@0 {
+			compatible = "rda,8810pl-apsyscon", "syscon";
+			reg = <0x0 0x1000>;
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+		};
+
 		timer@10000 {
 			compatible = "rda,8810pl-timer";
 			reg = <0x10000 0x1000>;

-- 
2.51.0
Re: [PATCH 11/25] dts: unisoc: rda8810pl: Enable clock/reset driver
Posted by Krzysztof Kozlowski 2 weeks, 1 day ago
On 17/09/2025 22:25, Dang Huynh via B4 Relay wrote:
> From: Dang Huynh <dang.huynh@mainlining.org>
> 
> Enable RDA8810PL Clock and Reset driver so we can use it for various
> subsystems.
> 
> Signed-off-by: Dang Huynh <dang.huynh@mainlining.org>

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

You use random prefixes... This is "ARM: dts:" and the drivers ARE NOT
"drivers:".


> ---
>  arch/arm/boot/dts/unisoc/rda8810pl.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
Best regards,
Krzysztof