Harry,
On 9/29/25 6:50 AM, Harry Wentland wrote:
>
>
> On 2025-09-17 20:43, Nícolas F. R. A. Prado wrote:
>> Pass the state of the post-blend color pipeline client cap to the atomic
>> state so that drivers can rely on it to enable color pipeline
>> functionality and ignore the deprecated color management CRTC
>> properties.
>>
>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>> ---
>> drivers/gpu/drm/drm_atomic_uapi.c | 1 +
>> include/drm/drm_atomic.h | 20 ++++++++++++++++++++
>> 2 files changed, 21 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/
>> drm_atomic_uapi.c
>> index
>> f5125fa3fa28ff2a6ff07fd7cf07d4bdf77ab738..56a440a9390c7730c4c41b491f29b933a2bbb889 100644
>> --- a/drivers/gpu/drm/drm_atomic_uapi.c
>> +++ b/drivers/gpu/drm/drm_atomic_uapi.c
>> @@ -1660,6 +1660,7 @@ int drm_mode_atomic_ioctl(struct drm_device *dev,
>> state->acquire_ctx = &ctx;
>> state->allow_modeset = !!(arg->flags &
>> DRM_MODE_ATOMIC_ALLOW_MODESET);
>> state->plane_color_pipeline = file_priv->plane_color_pipeline;
>> + state->post_blend_color_pipeline = file_priv-
>> >post_blend_color_pipeline;
>> retry:
>> copied_objs = 0;
>> diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
>> index
>> 678708df9cdb90b4266127193a92183069f18688..8c42c584aefbf0034b2163d90538e80099b0dadb 100644
>> --- a/include/drm/drm_atomic.h
>> +++ b/include/drm/drm_atomic.h
>> @@ -482,6 +482,26 @@ struct drm_atomic_state {
>> */
>> bool plane_color_pipeline : 1;
>> + /**
>> + * @post_blend_color_pipeline:
>> + *
>> + * Indicates whether this atomic state originated with a client that
>> + * set the DRM_CLIENT_CAP_POST_BLEND_COLOR_PIPELINE.
>> + *
>> + * Drivers and helper functions should use this to ignore legacy
>> + * properties that are incompatible with the drm_crtc COLOR_PIPELINE
>> + * behavior, such as:
>> + *
>> + * - GAMMA_LUT
>> + * - DEGAMMA_LUT
>> + * - GAMMA_LUT_SIZE
>> + * - CTM
>> + *
>> + * or any other driver-specific properties that might affect pixel
>> + * values.
>> + */
>> + bool post_blend_color_pipeline : 1;
>
> As with the client cap name, I recommend calling this
> crtc_color_pipeline.
Agreed. As per the rest of the comments, I think it's worth moving all
naming in this series from post_blend to crtc, matching the criteria
used in plane (a.k.a. pre-blend) color pipelines.
Will submit the related changes in v3.
Regards,
--
Ariel D'Alessandro
Software Engineer
Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
Registered in England & Wales, no. 5513718