[PATCH] iio: adc: ad7124: use AD7124_MAX_CHANNELS

David Lechner posted 1 patch 2 weeks ago
drivers/iio/adc/ad7124.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] iio: adc: ad7124: use AD7124_MAX_CHANNELS
Posted by David Lechner 2 weeks ago
Use AD7124_MAX_CHANNELS macro instead of hardcoding 16 in
ad7124_disable_all(). We already have the macro, so we should use it.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 drivers/iio/adc/ad7124.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
index c24f3d5127cb83eeab0cf37882446fc994173274..9ace3e0914f5acab695c0382df758f56f333ae72 100644
--- a/drivers/iio/adc/ad7124.c
+++ b/drivers/iio/adc/ad7124.c
@@ -702,7 +702,7 @@ static int ad7124_disable_all(struct ad_sigma_delta *sd)
 	int ret;
 	int i;
 
-	for (i = 0; i < 16; i++) {
+	for (i = 0; i < AD7124_MAX_CHANNELS; i++) {
 		ret = ad7124_disable_one(sd, i);
 		if (ret < 0)
 			return ret;

---
base-commit: 561285d048053fec8a3d6d1e3ddc60df11c393a0
change-id: 20250917-iio-adc-ad7124-use-ad7124_max_channels-37e2537d7446

Best regards,
-- 
David Lechner <dlechner@baylibre.com>
Re: [PATCH] iio: adc: ad7124: use AD7124_MAX_CHANNELS
Posted by Nuno Sá 2 weeks ago
On Wed, 2025-09-17 at 09:17 -0500, David Lechner wrote:
> Use AD7124_MAX_CHANNELS macro instead of hardcoding 16 in
> ad7124_disable_all(). We already have the macro, so we should use it.
> 
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

>  drivers/iio/adc/ad7124.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> index
> c24f3d5127cb83eeab0cf37882446fc994173274..9ace3e0914f5acab695c0382df758f56f333
> ae72 100644
> --- a/drivers/iio/adc/ad7124.c
> +++ b/drivers/iio/adc/ad7124.c
> @@ -702,7 +702,7 @@ static int ad7124_disable_all(struct ad_sigma_delta *sd)
>  	int ret;
>  	int i;
>  
> -	for (i = 0; i < 16; i++) {
> +	for (i = 0; i < AD7124_MAX_CHANNELS; i++) {
>  		ret = ad7124_disable_one(sd, i);
>  		if (ret < 0)
>  			return ret;
> 
> ---
> base-commit: 561285d048053fec8a3d6d1e3ddc60df11c393a0
> change-id: 20250917-iio-adc-ad7124-use-ad7124_max_channels-37e2537d7446
> 
> Best regards,