[PATCH 0/2] iio: adc: ad7124: drop nr field

David Lechner posted 2 patches 2 weeks ago
drivers/iio/adc/ad7124.c | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
[PATCH 0/2] iio: adc: ad7124: drop nr field
Posted by David Lechner 2 weeks ago
The motivation behind this series was to remove the `nr` field in struct
ad7124_channel since it is duplicating the same value as struct
iio_chan_spec.address (and duplicated again by .scan_index).

When it came to actually doing that though, I found that it was easier
to first clean things up by removing the ad7124_enable_channel()
function - which is a nice cleanup by itself. So ended up with 2 patches
that end with the same result without ever mentioning the duplication.

---
David Lechner (2):
      iio: adc: ad7124: inline ad7124_enable_channel()
      iio: adc: ad7124: remove unused `nr` field

 drivers/iio/adc/ad7124.c | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)
---
base-commit: 561285d048053fec8a3d6d1e3ddc60df11c393a0
change-id: 20250917-iio-adc-ad7124-drop-nr-field-518102218a61

Best regards,
-- 
David Lechner <dlechner@baylibre.com>
Re: [PATCH 0/2] iio: adc: ad7124: drop nr field
Posted by Nuno Sá 1 week, 6 days ago
On Wed, 2025-09-17 at 15:39 -0500, David Lechner wrote:
> The motivation behind this series was to remove the `nr` field in struct
> ad7124_channel since it is duplicating the same value as struct
> iio_chan_spec.address (and duplicated again by .scan_index).
> 
> When it came to actually doing that though, I found that it was easier
> to first clean things up by removing the ad7124_enable_channel()
> function - which is a nice cleanup by itself. So ended up with 2 patches
> that end with the same result without ever mentioning the duplication.
> 
> ---
> David Lechner (2):
>       iio: adc: ad7124: inline ad7124_enable_channel()
>       iio: adc: ad7124: remove unused `nr` field
> 
>  drivers/iio/adc/ad7124.c | 19 ++++++-------------
>  1 file changed, 6 insertions(+), 13 deletions(-)
> ---
> base-commit: 561285d048053fec8a3d6d1e3ddc60df11c393a0
> change-id: 20250917-iio-adc-ad7124-drop-nr-field-518102218a61
> 
> Best regards,

Reviewed-by: Nuno Sá <nuno.sa@analog.com>