[PATCH] platform/x86:intel/pmc: Replace dev_warn() with dev_dbg()

Xi Pardee posted 1 patch 2 weeks, 1 day ago
drivers/platform/x86/intel/pmc/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] platform/x86:intel/pmc: Replace dev_warn() with dev_dbg()
Posted by Xi Pardee 2 weeks, 1 day ago
Replace dev_warn() with dev_dbg() to reduce unnecessary warning messages.
When the low power mode priority register contains invalid data, the Intel
PMC Core driver can still utilize the default priority list. This scenario
is more suited for debug information rather than warning.

Signed-off-by: Xi Pardee <xi.pardee@linux.intel.com>
---
 drivers/platform/x86/intel/pmc/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c
index de2dbf4ad65e0..5729810e5a485 100644
--- a/drivers/platform/x86/intel/pmc/core.c
+++ b/drivers/platform/x86/intel/pmc/core.c
@@ -1244,7 +1244,7 @@ void pmc_core_get_low_power_modes(struct pmc_dev *pmcdev)
 		for (mode = 0; mode < LPM_MAX_NUM_MODES; mode++)
 			pri_order[mode_order[mode]] = mode;
 	else
-		dev_warn(&pmcdev->pdev->dev,
+		dev_dbg(&pmcdev->pdev->dev,
 			 "Assuming a default substate order for this platform\n");
 
 	/*
-- 
2.43.0
Re: [PATCH] platform/x86:intel/pmc: Replace dev_warn() with dev_dbg()
Posted by Ilpo Järvinen 1 week, 2 days ago
On Tue, 16 Sep 2025 12:13:32 -0700, Xi Pardee wrote:

> Replace dev_warn() with dev_dbg() to reduce unnecessary warning messages.
> When the low power mode priority register contains invalid data, the Intel
> PMC Core driver can still utilize the default priority list. This scenario
> is more suited for debug information rather than warning.
> 
> 


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86:intel/pmc: Replace dev_warn() with dev_dbg()
      commit: bf726cdc9d4fabcf1ebd50f6fce5121acc7447bb

--
 i.