kunit: Extend kconfig help text for KUNIT_UML_PCI

[PATCH] kunit: Extend kconfig help text for KUNIT_UML_PCI

Posted by Thomas Weißschuh 2 weeks, 2 days ago

Checkpatch.pl expects at least 4 lines of help text.

Extend the help text to make checkpatch.pl happy.

Fixes: 031cdd3bc3f3 ("kunit: Enable PCI on UML without triggering WARN()")
Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
Link: https://lore.kernel.org/lkml/3dc95227-2be9-48a0-bdea-3f283d9b2a38@linuxfoundation.org/
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
Feel free to fold this into the original commit.
---
 lib/kunit/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/kunit/Kconfig b/lib/kunit/Kconfig
index 1823539e96da30e165fa8d395ccbd3f6754c836e..7a6af361d2fc6276b9667be8c694b0c80e33c1e8 100644
--- a/lib/kunit/Kconfig
+++ b/lib/kunit/Kconfig
@@ -112,5 +112,9 @@ config KUNIT_UML_PCI
 	select UML_PCI
 	help
 	  Enables the PCI subsystem on UML for use by KUnit tests.
+	  Some KUnit tests require the PCI core which is not enabled by
+	  default on UML.
+
+	  If unsure, say N.
 
 endif # KUNIT

---
base-commit: f20e264262f1e6a6e5302249e37da355d844b52b
change-id: 20250916-kunit-pci-kconfig-357264bb45f4

Best regards,
-- 
Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Re: [PATCH] kunit: Extend kconfig help text for KUNIT_UML_PCI

Posted by David Gow 2 weeks, 2 days ago

On Tue, 16 Sept 2025 at 14:16, Thomas Weißschuh
<thomas.weissschuh@linutronix.de> wrote:
>
> Checkpatch.pl expects at least 4 lines of help text.
>
> Extend the help text to make checkpatch.pl happy.
>
> Fixes: 031cdd3bc3f3 ("kunit: Enable PCI on UML without triggering WARN()")
> Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
> Link: https://lore.kernel.org/lkml/3dc95227-2be9-48a0-bdea-3f283d9b2a38@linuxfoundation.org/
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---

Reviewed-by: David Gow <davidgow@google.com>

Thanks,
-- David