[PATCH 2/2] slab: mark slab->obj_exts allocation failures unconditionally

Suren Baghdasaryan posted 2 patches 2 weeks, 2 days ago
[PATCH 2/2] slab: mark slab->obj_exts allocation failures unconditionally
Posted by Suren Baghdasaryan 2 weeks, 2 days ago
alloc_slab_obj_exts() should mark failed obj_exts vector allocations
independent on whether the vector is being allocated for a new or an
existing slab. Current implementation skips doing this for existing
slabs. Fix this by marking failed allocations unconditionally.

Fixes: 09c46563ff6d ("codetag: debug: introduce OBJEXTS_ALLOC_FAIL to mark failed slab_ext allocations")
Reported-by: Shakeel Butt <shakeel.butt@linux.dev>
Closes: https://lore.kernel.org/all/avhakjldsgczmq356gkwmvfilyvf7o6temvcmtt5lqd4fhp5rk@47gp2ropyixg/
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Cc: stable@vger.kernel.org # v6.10+
---
 mm/slub.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index af343ca570b5..cab4e7822393 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2029,8 +2029,7 @@ int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s,
 			   slab_nid(slab));
 	if (!vec) {
 		/* Mark vectors which failed to allocate */
-		if (new_slab)
-			mark_failed_objexts_alloc(slab);
+		mark_failed_objexts_alloc(slab);
 
 		return -ENOMEM;
 	}
-- 
2.51.0.384.g4c02a37b29-goog
Re: [PATCH 2/2] slab: mark slab->obj_exts allocation failures unconditionally
Posted by Shakeel Butt 2 weeks, 2 days ago
On Mon, Sep 15, 2025 at 01:09:18PM -0700, Suren Baghdasaryan wrote:
> alloc_slab_obj_exts() should mark failed obj_exts vector allocations
> independent on whether the vector is being allocated for a new or an
> existing slab. Current implementation skips doing this for existing
> slabs. Fix this by marking failed allocations unconditionally.
> 
> Fixes: 09c46563ff6d ("codetag: debug: introduce OBJEXTS_ALLOC_FAIL to mark failed slab_ext allocations")
> Reported-by: Shakeel Butt <shakeel.butt@linux.dev>
> Closes: https://lore.kernel.org/all/avhakjldsgczmq356gkwmvfilyvf7o6temvcmtt5lqd4fhp5rk@47gp2ropyixg/
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> Cc: stable@vger.kernel.org # v6.10+

Acked-by: Shakeel Butt <shakeel.butt@linux.dev>