xtensa: use HZ_PER_MHZ in platform_calibrate_ccount

[PATCH] xtensa: use HZ_PER_MHZ in platform_calibrate_ccount

Posted by Thorsten Blum 2 weeks, 3 days ago

Replace the hardcoded 1000000UL with the HZ_PER_MHZ unit macro, and add
a space in "10 MHz" to improve the readability of the error message.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 arch/xtensa/kernel/platform.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/xtensa/kernel/platform.c b/arch/xtensa/kernel/platform.c
index 926b8bf0f14c..f14713060fd4 100644
--- a/arch/xtensa/kernel/platform.c
+++ b/arch/xtensa/kernel/platform.c
@@ -14,6 +14,7 @@
 
 #include <linux/printk.h>
 #include <linux/types.h>
+#include <linux/units.h>
 #include <asm/platform.h>
 #include <asm/timex.h>
 
@@ -38,7 +39,7 @@ void __weak platform_idle(void)
 #ifdef CONFIG_XTENSA_CALIBRATE_CCOUNT
 void __weak platform_calibrate_ccount(void)
 {
-	pr_err("ERROR: Cannot calibrate cpu frequency! Assuming 10MHz.\n");
-	ccount_freq = 10 * 1000000UL;
+	pr_err("ERROR: Cannot calibrate cpu frequency! Assuming 10 MHz.\n");
+	ccount_freq = 10 * HZ_PER_MHZ;
 }
 #endif
-- 
2.51.0

Re: [PATCH] xtensa: use HZ_PER_MHZ in platform_calibrate_ccount

Posted by Max Filippov 2 weeks, 2 days ago

On Mon, Sep 15, 2025 at 5:06 AM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Replace the hardcoded 1000000UL with the HZ_PER_MHZ unit macro, and add
> a space in "10 MHz" to improve the readability of the error message.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  arch/xtensa/kernel/platform.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Thanks. Applied to my xtensa tree.

-- Max