[PATCH v1] perf test: Stat std output don't fail metric only

Ian Rogers posted 1 patch 4 months, 3 weeks ago
tools/perf/tests/shell/stat+std_output.sh | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
[PATCH v1] perf test: Stat std output don't fail metric only
Posted by Ian Rogers 4 months, 3 weeks ago
When running on a hypervisor the expected IPC metric may be missing as
the events may fail to be read. Don't expect metric output for this
test to avoid it failing.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/tests/shell/stat+std_output.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/perf/tests/shell/stat+std_output.sh b/tools/perf/tests/shell/stat+std_output.sh
index 6fee67693ba7..ec41f24299d9 100755
--- a/tools/perf/tests/shell/stat+std_output.sh
+++ b/tools/perf/tests/shell/stat+std_output.sh
@@ -90,7 +90,11 @@ function commachecker()
 		}
 	done < "${stat_output}"
 
-	[ $metric_only -eq 1 ] && exit 1
+	if [ $metric_only -ne 1 ]
+	then
+		echo "Missing metric only output in:"
+		cat "${stat_output}"
+	fi
 	return 0
 }
 
-- 
2.51.0.384.g4c02a37b29-goog
Re: [PATCH v1] perf test: Stat std output don't fail metric only
Posted by Arnaldo Carvalho de Melo 4 months, 1 week ago
On Sun, Sep 14, 2025 at 11:21:40AM -0700, Ian Rogers wrote:
> When running on a hypervisor the expected IPC metric may be missing as
> the events may fail to be read. Don't expect metric output for this
> test to avoid it failing.

Thanks, applied to perf-tools-next,

- Arnaldo
 
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/tests/shell/stat+std_output.sh | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/shell/stat+std_output.sh b/tools/perf/tests/shell/stat+std_output.sh
> index 6fee67693ba7..ec41f24299d9 100755
> --- a/tools/perf/tests/shell/stat+std_output.sh
> +++ b/tools/perf/tests/shell/stat+std_output.sh
> @@ -90,7 +90,11 @@ function commachecker()
>  		}
>  	done < "${stat_output}"
>  
> -	[ $metric_only -eq 1 ] && exit 1
> +	if [ $metric_only -ne 1 ]
> +	then
> +		echo "Missing metric only output in:"
> +		cat "${stat_output}"
> +	fi
>  	return 0
>  }
>  
> -- 
> 2.51.0.384.g4c02a37b29-goog
>