[PATCH net-next v12 4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3

Vivian Wang posted 5 patches 2 weeks, 4 days ago
[PATCH net-next v12 4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3
Posted by Vivian Wang 2 weeks, 4 days ago
Banana Pi BPI-F3 uses an RGMII PHY for each port and uses GPIO for PHY
reset.

Tested-by: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>
Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Reviewed-by: Yixun Lan <dlan@gentoo.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
 arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 48 +++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
index fe22c747c5012fe56d42ac8a7efdbbdb694f31b6..33e223cefd4bd3a12fae176ac6cddd8276cb53dc 100644
--- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
@@ -11,6 +11,8 @@ / {
 	compatible = "bananapi,bpi-f3", "spacemit,k1";
 
 	aliases {
+		ethernet0 = &eth0;
+		ethernet1 = &eth1;
 		serial0 = &uart0;
 	};
 
@@ -40,6 +42,52 @@ &emmc {
 	status = "okay";
 };
 
+&eth0 {
+	phy-handle = <&rgmii0>;
+	phy-mode = "rgmii-id";
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac0_cfg>;
+	rx-internal-delay-ps = <0>;
+	tx-internal-delay-ps = <0>;
+	status = "okay";
+
+	mdio-bus {
+		#address-cells = <0x1>;
+		#size-cells = <0x0>;
+
+		reset-gpios = <&gpio K1_GPIO(110) GPIO_ACTIVE_LOW>;
+		reset-delay-us = <10000>;
+		reset-post-delay-us = <100000>;
+
+		rgmii0: phy@1 {
+			reg = <0x1>;
+		};
+	};
+};
+
+&eth1 {
+	phy-handle = <&rgmii1>;
+	phy-mode = "rgmii-id";
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac1_cfg>;
+	rx-internal-delay-ps = <0>;
+	tx-internal-delay-ps = <250>;
+	status = "okay";
+
+	mdio-bus {
+		#address-cells = <0x1>;
+		#size-cells = <0x0>;
+
+		reset-gpios = <&gpio K1_GPIO(115) GPIO_ACTIVE_LOW>;
+		reset-delay-us = <10000>;
+		reset-post-delay-us = <100000>;
+
+		rgmii1: phy@1 {
+			reg = <0x1>;
+		};
+	};
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_2_cfg>;

-- 
2.50.1
Re: [PATCH net-next v12 4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3
Posted by Vivian Wang 2 weeks, 4 days ago
On 9/14/25 12:23, Vivian Wang wrote:
> Banana Pi BPI-F3 uses an RGMII PHY for each port and uses GPIO for PHY
> reset.
>
> Tested-by: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>
> Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
> Reviewed-by: Yixun Lan <dlan@gentoo.org>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
>  arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 48 +++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> index fe22c747c5012fe56d42ac8a7efdbbdb694f31b6..33e223cefd4bd3a12fae176ac6cddd8276cb53dc 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> @@ -11,6 +11,8 @@ / {
>  	compatible = "bananapi,bpi-f3", "spacemit,k1";
>  
>  	aliases {
> +		ethernet0 = &eth0;
> +		ethernet1 = &eth1;

Hi Andrew,

I added these two aliases in v12, but kept your Reviewed-by for v11
because this is fairly trivial. Same for patch 5.

Is this okay?

Thanks,
Vivian "dramforever" Wang
Re: [PATCH net-next v12 4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3
Posted by Andrew Lunn 2 weeks, 4 days ago
On Sun, Sep 14, 2025 at 12:31:04PM +0800, Vivian Wang wrote:
> On 9/14/25 12:23, Vivian Wang wrote:
> > Banana Pi BPI-F3 uses an RGMII PHY for each port and uses GPIO for PHY
> > reset.
> >
> > Tested-by: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>
> > Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
> > Reviewed-by: Yixun Lan <dlan@gentoo.org>
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> >  arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 48 +++++++++++++++++++++++++
> >  1 file changed, 48 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> > index fe22c747c5012fe56d42ac8a7efdbbdb694f31b6..33e223cefd4bd3a12fae176ac6cddd8276cb53dc 100644
> > --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> > +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> > @@ -11,6 +11,8 @@ / {
> >  	compatible = "bananapi,bpi-f3", "spacemit,k1";
> >  
> >  	aliases {
> > +		ethernet0 = &eth0;
> > +		ethernet1 = &eth1;
> 
> Hi Andrew,
> 
> I added these two aliases in v12, but kept your Reviewed-by for v11
> because this is fairly trivial. Same for patch 5.
> 
> Is this okay?

Yes, this is fine.

	Andrew