firewire: core: use macro for magic numbers related to bus manager work

[PATCH 0/2] firewire: core: use macro for magic numbers related to bus manager work

Takashi Sakamoto posted 2 patches 2 weeks, 5 days ago

Download series mbox

drivers/firewire/core-card.c     | 14 +++++++++-----
drivers/firewire/core-topology.c |  2 +-
drivers/firewire/core.h          |  6 ++++++
3 files changed, 16 insertions(+), 6 deletions(-)

Expand all Fold all

[PATCH 0/2] firewire: core: use macro for magic numbers related to bus manager work

Posted by Takashi Sakamoto 2 weeks, 5 days ago

Hi,

Some magic numbers are used for bus manager work. This patchset adds
some macros to replace the magic numbers.

* 0x3f: BUS_MANAGER_ID_NOT_REGISTERED
* 0: GAP_COUNT_MISMATCHED

Takashi Sakamoto (2):
  firewire: core: use macro expression for gap count mismatch
  firewire: core: use macro expression for not-registered state of
    BUS_MANAGER_ID

 drivers/firewire/core-card.c     | 14 +++++++++-----
 drivers/firewire/core-topology.c |  2 +-
 drivers/firewire/core.h          |  6 ++++++
 3 files changed, 16 insertions(+), 6 deletions(-)


base-commit: 136d8a6f73fee0686d163dca91fdffb35e25f092
-- 
2.48.1

Re: [PATCH 0/2] firewire: core: use macro for magic numbers related to bus manager work

Posted by Takashi Sakamoto 2 weeks, 4 days ago

On Sat, Sep 13, 2025 at 07:57:35PM +0900, Takashi Sakamoto wrote:
> Hi,
> 
> Some magic numbers are used for bus manager work. This patchset adds
> some macros to replace the magic numbers.
> 
> * 0x3f: BUS_MANAGER_ID_NOT_REGISTERED
> * 0: GAP_COUNT_MISMATCHED
> 
> Takashi Sakamoto (2):
>   firewire: core: use macro expression for gap count mismatch
>   firewire: core: use macro expression for not-registered state of
>     BUS_MANAGER_ID
> 
>  drivers/firewire/core-card.c     | 14 +++++++++-----
>  drivers/firewire/core-topology.c |  2 +-
>  drivers/firewire/core.h          |  6 ++++++
>  3 files changed, 16 insertions(+), 6 deletions(-)

Applied to for-next branch.


Regards

Takashi Sakamoto