1. Patchew
  2. linux
  3. View series

[PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator

Shuai Xue posted 1 patch 4 months, 4 weeks ago 
drivers/acpi/numa/srat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator
Posted by Shuai Xue 4 months, 4 weeks ago 
The Generic Initiator Affinity Structure in SRAT table uses device
handle type field to indicate the device type. According to ACPI
specification, the device handle type value of 1 represents PCI device,
not 0.

Fixes: 894c26a1c274 ("ACPI: Support Generic Initiator only domains")
Reported-by: Wu Zongyong <wuzongyong@linux.alibaba.com>
Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
---
changes since v1: drop changes in actbl3.h to make it easy to progress per Jonathan
---
 drivers/acpi/numa/srat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c
index 53816dfab645..aa87ee1583a4 100644
--- a/drivers/acpi/numa/srat.c
+++ b/drivers/acpi/numa/srat.c
@@ -237,7 +237,7 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
 		struct acpi_srat_generic_affinity *p =
 			(struct acpi_srat_generic_affinity *)header;
 
-		if (p->device_handle_type == 0) {
+		if (p->device_handle_type == 1) {
 			/*
 			 * For pci devices this may be the only place they
 			 * are assigned a proximity domain
-- 
2.39.3
Re: [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator
Posted by Jonathan Cameron 4 months, 3 weeks ago 
On Sat, 13 Sep 2025 10:32:24 +0800
Shuai Xue <xueshuai@linux.alibaba.com> wrote:

> The Generic Initiator Affinity Structure in SRAT table uses device
> handle type field to indicate the device type. According to ACPI
> specification, the device handle type value of 1 represents PCI device,
> not 0.
> 
> Fixes: 894c26a1c274 ("ACPI: Support Generic Initiator only domains")
> Reported-by: Wu Zongyong <wuzongyong@linux.alibaba.com>
> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

Thanks!

> ---
> changes since v1: drop changes in actbl3.h to make it easy to progress per Jonathan
> ---
>  drivers/acpi/numa/srat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c
> index 53816dfab645..aa87ee1583a4 100644
> --- a/drivers/acpi/numa/srat.c
> +++ b/drivers/acpi/numa/srat.c
> @@ -237,7 +237,7 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
>  		struct acpi_srat_generic_affinity *p =
>  			(struct acpi_srat_generic_affinity *)header;
>  
> -		if (p->device_handle_type == 0) {
> +		if (p->device_handle_type == 1) {
>  			/*
>  			 * For pci devices this may be the only place they
>  			 * are assigned a proximity domain
Re: [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator
Posted by Shuai Xue 3 months, 2 weeks ago 

在 2025/9/15 16:35, Jonathan Cameron 写道:
> On Sat, 13 Sep 2025 10:32:24 +0800
> Shuai Xue <xueshuai@linux.alibaba.com> wrote:
> 
>> The Generic Initiator Affinity Structure in SRAT table uses device
>> handle type field to indicate the device type. According to ACPI
>> specification, the device handle type value of 1 represents PCI device,
>> not 0.
>>
>> Fixes: 894c26a1c274 ("ACPI: Support Generic Initiator only domains")
>> Reported-by: Wu Zongyong <wuzongyong@linux.alibaba.com>
>> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
> 
> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> 
> Thanks!
> 
>> ---
>> changes since v1: drop changes in actbl3.h to make it easy to progress per Jonathan
>> ---


Hi, Rafael,

Gentle ping.

Are you happy to pick this bugfix up in this cycle?

Thanks.
Shuai
Re: [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator
Posted by Rafael J. Wysocki 3 months, 2 weeks ago 
On Tue, Oct 21, 2025 at 8:55 AM Shuai Xue <xueshuai@linux.alibaba.com> wrote:
>
>
>
> 在 2025/9/15 16:35, Jonathan Cameron 写道:
> > On Sat, 13 Sep 2025 10:32:24 +0800
> > Shuai Xue <xueshuai@linux.alibaba.com> wrote:
> >
> >> The Generic Initiator Affinity Structure in SRAT table uses device
> >> handle type field to indicate the device type. According to ACPI
> >> specification, the device handle type value of 1 represents PCI device,
> >> not 0.
> >>
> >> Fixes: 894c26a1c274 ("ACPI: Support Generic Initiator only domains")
> >> Reported-by: Wu Zongyong <wuzongyong@linux.alibaba.com>
> >> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
> >
> > Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> >
> > Thanks!
> >
> >> ---
> >> changes since v1: drop changes in actbl3.h to make it easy to progress per Jonathan
> >> ---
>
>
> Hi, Rafael,
>
> Gentle ping.
>
> Are you happy to pick this bugfix up in this cycle?

drives/acpi/numa/ is maintained by Dave.
Re: [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator
Posted by Dave Jiang 3 months, 2 weeks ago 

On 10/21/25 6:30 AM, Rafael J. Wysocki wrote:
> On Tue, Oct 21, 2025 at 8:55 AM Shuai Xue <xueshuai@linux.alibaba.com> wrote:
>>
>>
>>
>> 在 2025/9/15 16:35, Jonathan Cameron 写道:
>>> On Sat, 13 Sep 2025 10:32:24 +0800
>>> Shuai Xue <xueshuai@linux.alibaba.com> wrote:
>>>
>>>> The Generic Initiator Affinity Structure in SRAT table uses device
>>>> handle type field to indicate the device type. According to ACPI
>>>> specification, the device handle type value of 1 represents PCI device,
>>>> not 0.
>>>>
>>>> Fixes: 894c26a1c274 ("ACPI: Support Generic Initiator only domains")
>>>> Reported-by: Wu Zongyong <wuzongyong@linux.alibaba.com>
>>>> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
>>>
>>> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
>>>
>>> Thanks!
>>>
>>>> ---
>>>> changes since v1: drop changes in actbl3.h to make it easy to progress per Jonathan
>>>> ---
>>
>>
>> Hi, Rafael,
>>
>> Gentle ping.
>>
>> Are you happy to pick this bugfix up in this cycle?
> 
> drives/acpi/numa/ is maintained by Dave.

Applied to cxl/fixes
7c3643f204edf1
Re: [PATCH v2] acpi,srat: Fix incorrect device handle check for Generic Initiator
Posted by Shuai Xue 3 months, 2 weeks ago 

在 2025/10/21 23:06, Dave Jiang 写道:
> 
> 
> On 10/21/25 6:30 AM, Rafael J. Wysocki wrote:
>> On Tue, Oct 21, 2025 at 8:55 AM Shuai Xue <xueshuai@linux.alibaba.com> wrote:
>>>
>>>
>>>
>>> 在 2025/9/15 16:35, Jonathan Cameron 写道:
>>>> On Sat, 13 Sep 2025 10:32:24 +0800
>>>> Shuai Xue <xueshuai@linux.alibaba.com> wrote:
>>>>
>>>>> The Generic Initiator Affinity Structure in SRAT table uses device
>>>>> handle type field to indicate the device type. According to ACPI
>>>>> specification, the device handle type value of 1 represents PCI device,
>>>>> not 0.
>>>>>
>>>>> Fixes: 894c26a1c274 ("ACPI: Support Generic Initiator only domains")
>>>>> Reported-by: Wu Zongyong <wuzongyong@linux.alibaba.com>
>>>>> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
>>>>
>>>> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
>>>>
>>>> Thanks!
>>>>
>>>>> ---
>>>>> changes since v1: drop changes in actbl3.h to make it easy to progress per Jonathan
>>>>> ---
>>>
>>>
>>> Hi, Rafael,
>>>
>>> Gentle ping.
>>>
>>> Are you happy to pick this bugfix up in this cycle?
>>
>> drives/acpi/numa/ is maintained by Dave.
> 
> Applied to cxl/fixes
> 7c3643f204edf1


Thanks.
Shuai

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.